From patchwork Wed Aug 19 16:19:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enric Balletbo i Serra X-Patchwork-Id: 11724579 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C47AD13A4 for ; Wed, 19 Aug 2020 16:19:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D7412078D for ; Wed, 19 Aug 2020 16:19:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rNJI4f3w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D7412078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=/04ZHmzY2oIyEEcTSPBXorothWjm6PV6i1UMpf0ZAXw=; b=rNJI4f3w29HyRklDOdy0icdJhi i7m63BRH2ewOSaxmedUbyPE+ZOtZ7IB5/CcSvfzwWXD5YSgzu3tOpfnTdUmIWc4oxNG/0CmuEkxOw BVy1GmjOYrkMTJWPhAdJX1Bzc5d0x9W9bVU+ZKvhn7mD07NQ9W3R+2kPC8ONN/qnqRjToz0zpBIcG xtjTzkNeVfrmrb6Awl0+W3ky3YwOeaJgFwcxbpx2EHga4Hwn/xKv1J6Dl3IGu3zZ6zCVgBQjvp3qv KDJ///6NMwinp4v6P4SNYOBe+HyEccGG6hx8rgbpoX9iqtkvTMTT1VQsFtePMjgHlq9kOsgA/3ASS Npa4GpGA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8Qo5-0005LB-CX; Wed, 19 Aug 2020 16:19:21 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8Qo1-0005K1-Ul; Wed, 19 Aug 2020 16:19:19 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id A77BF299C37 From: Enric Balletbo i Serra To: linux-kernel@vger.kernel.org Subject: [PATCH] Revert "irqchip/mtk-sysirq: Convert to a platform driver" Date: Wed, 19 Aug 2020 18:19:07 +0200 Message-Id: <20200819161907.1155110-1-enric.balletbo@collabora.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_121918_104476_400A5310 X-CRM114-Status: GOOD ( 15.46 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [46.235.227.227 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, Jason Cooper , Saravana Kannan , Marc Zyngier , Hanks Chen , linux-mediatek@lists.infradead.org, hsinyi@chromium.org, matthias.bgg@gmail.com, Frank Wunderlich , Collabora Kernel ML , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This reverts commit f97dbf48ca43009e8b8bcdf07f47fc9f06149b36. Although converting to a platform driver sounds good, doing this for the MediaTek devices has a side effect, the probe of the driver is delayed and the interrupt controller is not available for other drivers when they probe. For MT8173 that means that the `systimer` and `mtk_cmdq` drivers will fail to probe with the following errors: [ 0.000197] Failed to map interrupt for /soc/timer@10008000 [ 0.000209] Failed to initialize '/soc/timer@10008000': -22 [ 0.067386] mtk_cmdq 10212000.mailbox: failed to register ISR (-22) For MT8183, apart from the above errors, you will get the `pinctrl` driver without the EINT support, because the `pinctrl` is probed before the interrupt controller, for what is worth, then it doesn't booting properly. [ 0.062309] mt8183-pinctrl 10005000.pinctrl: Failed to add EINT, but pinctrl still can work While deferring these drivers until the irqchip is available could be an option, at this point, seems reasonable to revert this commit for now until all these drivers are properly handling/deferring when the irqchip is not available. Cc: Saravana Kannan Cc: Marc Zyngier Cc: Hanks Chen Fixes: f97dbf48ca43 ("irqchip/mtk-sysirq: Convert to a platform driver") Signed-off-by: Enric Balletbo i Serra --- drivers/irqchip/irq-mtk-sysirq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c index 7299c5ab4d10..6ff98b87e5c0 100644 --- a/drivers/irqchip/irq-mtk-sysirq.c +++ b/drivers/irqchip/irq-mtk-sysirq.c @@ -231,6 +231,4 @@ static int __init mtk_sysirq_of_init(struct device_node *node, kfree(chip_data); return ret; } -IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_sysirq) -IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init) -IRQCHIP_PLATFORM_DRIVER_END(mtk_sysirq) +IRQCHIP_DECLARE(mtk_sysirq, "mediatek,mt6577-sysirq", mtk_sysirq_of_init);