| Message ID | 20200821161401.11307-2-l.stelmach@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/9] spi: spi-s3c64xx: swap s3c64xx_spi_set_cs() and s3c64xx_enable_datapath() | expand |
On Fri, Aug 21, 2020 at 06:13:53PM +0200, Łukasz Stelmach wrote: > This and the next patch fix issues with DMA transfers bigger than Just: "Fix issues with DMA transfers..." The order of patches could change when applying and backporting. Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof > 512 bytes on Exynos3250. Without the patches such transfers fail > to complete. This solution to the problem is found in the vendor kernel > for ARTIK5 boards based on Exynos3250. > > Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com> > --- > drivers/spi/spi-s3c64xx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 924b24441789..26c7cb79cd78 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -685,11 +685,11 @@ static int s3c64xx_spi_transfer_one(struct spi_master *master, > sdd->state &= ~RXBUSY; > sdd->state &= ~TXBUSY; > > - s3c64xx_enable_datapath(sdd, xfer, use_dma); > - > /* Start the signals */ > s3c64xx_spi_set_cs(spi, true); > > + s3c64xx_enable_datapath(sdd, xfer, use_dma); > + > spin_unlock_irqrestore(&sdd->lock, flags); > > if (use_dma) > -- > 2.26.2 >
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 924b24441789..26c7cb79cd78 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -685,11 +685,11 @@ static int s3c64xx_spi_transfer_one(struct spi_master *master, sdd->state &= ~RXBUSY; sdd->state &= ~TXBUSY; - s3c64xx_enable_datapath(sdd, xfer, use_dma); - /* Start the signals */ s3c64xx_spi_set_cs(spi, true); + s3c64xx_enable_datapath(sdd, xfer, use_dma); + spin_unlock_irqrestore(&sdd->lock, flags); if (use_dma)
This and the next patch fix issues with DMA transfers bigger than 512 bytes on Exynos3250. Without the patches such transfers fail to complete. This solution to the problem is found in the vendor kernel for ARTIK5 boards based on Exynos3250. Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com> --- drivers/spi/spi-s3c64xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)