From patchwork Fri Aug 21 19:43:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 11730413 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 28241618 for ; Fri, 21 Aug 2020 19:54:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2F7320FC3 for ; Fri, 21 Aug 2020 19:54:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nPB8d301"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="h4th2Gwt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2F7320FC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jVzLZ5RrBPmdqQIDu73I2zDjCfZht89lNHdQOZPJyms=; b=nPB8d301BEFVdjM/RzCEJLuvr LDOLdtUBfiYyza5QQBpWsJTfetfxV5lwqfJ2cPCvFQRp3JNc3XeyGErxF/juswCrzzznHqmQGced/ ArP1YON803/7WsdV8NlPEHUIpqAc3H9L09a6IoQbU1fJadjNofg6MXxlQfo1nYaAowH7u+OCmzD79 ykIkZ+d56hyii7a15g4CBn3lIjdNMgqqfkEvycJmC+Fu8+vBKf1r1JHIZDUIdKyLARV4tUabz5Wl1 VVvG8KVw3z4baabkrO1I7nsVZ5mU6IMqEBE2RwVOFj8nEau89/Ym4WrXbDcJWXSai73sg+RyPgDdV 55dr0453Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9D7L-0003Fj-55; Fri, 21 Aug 2020 19:54:27 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9D6x-00034b-Ug for linux-arm-kernel@lists.infradead.org; Fri, 21 Aug 2020 19:54:05 +0000 Received: by mail-pg1-x543.google.com with SMTP id s15so1478185pgc.8 for ; Fri, 21 Aug 2020 12:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X7lCPABz4JNrayMBdAlXz/o0k5wzYACi9B/neD0BSpY=; b=h4th2Gwty/g8Cg6oI4xBM2C9OsM+YtTMFNWMQxaSJxeMsiGbGHmjIpyPzRqnDYUohj mZEWv+JTiMGCqWpGcvezka0JZwFqupIZBq+bYlxEMz2m2f5RPnDUM/esPBUqClXzhknr KDHkGu/E7WUrNYpV0Two51F+fgNxBgpigGGNs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X7lCPABz4JNrayMBdAlXz/o0k5wzYACi9B/neD0BSpY=; b=oNtxum0xJpaF7pFXtEHuN2AyeQ3/J9DACvUdwA1ADe8s2pSzpgrpJA6yOxERz06NUZ rEsGXa0UZP1ih2QDMpbo4cyrzj7Q5C69hH1PWysNEfArhoK2yuzU5p6dgrXntxXewHwV QLkzakAb5vM51PNnXF5Lk2fo6HCN/L2vJJjdZLJh3z6XUboJ5XT6JQEnKBvr9+VE3qUF LMF3LrkstCHVimwrhSzPaoyZvQBGKw+RFXuwPen3ozAUDJpNjfJ3Ue7OpDSG7jKkC01S 86PdH5s6haBQZZM0NtkF3qcYDMXCZ35awTpLCUw5LO2l+6dLIbxz4SRj0ItGL29FBcm7 xmWw== X-Gm-Message-State: AOAM530XgIP7VSEVtiH+3Ww3gKjflLBdZyrCDW20t4Dro6G24kYO6TmR wSPXtrsLImBIHnYRqx41kyFWmw== X-Google-Smtp-Source: ABdhPJxhC+bVf5xz8oKClettUbKDwzdI3ZXBGK3DWk9rxsSxl1YyINcFuh70sERopw/lGiEEpzQkVg== X-Received: by 2002:a63:cd46:: with SMTP id a6mr3322488pgj.267.1598039642059; Fri, 21 Aug 2020 12:54:02 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id l67sm3026438pga.41.2020.08.21.12.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2020 12:53:59 -0700 (PDT) From: Kees Cook To: Ingo Molnar Subject: [PATCH v6 25/29] x86/build: Warn on orphan section placement Date: Fri, 21 Aug 2020 12:43:06 -0700 Message-Id: <20200821194310.3089815-26-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200821194310.3089815-1-keescook@chromium.org> References: <20200821194310.3089815-1-keescook@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200821_155404_030522_DAFE88C1 X-CRM114-Status: GOOD ( 12.46 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:543 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, Kees Cook , Arnd Bergmann , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Arvind Sankar , Ingo Molnar , James Morse , Nathan Chancellor , Borislav Petkov , Peter Collingbourne , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly handled in the linker script. Now that all sections are explicitly handled, enable orphan section warnings. Signed-off-by: Kees Cook --- arch/x86/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/x86/Makefile b/arch/x86/Makefile index 4346ffb2e39f..ccacbf808552 100644 --- a/arch/x86/Makefile +++ b/arch/x86/Makefile @@ -209,6 +209,10 @@ ifdef CONFIG_X86_64 LDFLAGS_vmlinux += -z max-page-size=0x200000 endif +# We never want expected sections to be placed heuristically by the +# linker. All sections should be explicitly named in the linker script. +LDFLAGS_vmlinux += --orphan-handling=warn + archscripts: scripts_basic $(Q)$(MAKE) $(build)=arch/x86/tools relocs