From patchwork Fri Aug 21 19:42:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 11730373 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1C52F13B1 for ; Fri, 21 Aug 2020 19:44:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9D552076E for ; Fri, 21 Aug 2020 19:44:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zOdWG4cu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mPcfZIGu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9D552076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SfS33aJDhCJgkTSXUPkHruFqqib9eq9it1R/z01H5uI=; b=zOdWG4cuA4kHJyOCygNJ8fUKo 015L017tcoOs1mB8lNy3fPW3B0xEIoVNDjDl//hpSvHd7Vvzqy1o7nU/G3GoABov3+mVK6FUbFa2C Y84D0p+SkYL6XxCOdHT6vnG5broQvS52yoBrZCF/b2f23iIKV/yzzsuPqC0KRiRulDzu9Aj58Dggw lQVQhuM9tPseIkOs+ja/FYuAYxzClSz4SVNUEm0eqdgz0xanaMTUS7AfFJnD+IKaJAfnTboBbGzIk A7wY/tzuBG1OFpDNAy0nYk6xN9TBYRSiYpBicTOXyTd2GJxatsdYdkB0suvuaHMsd6+eef8qVfe7w 9oTWIfTpw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9Cxx-0006ep-4b; Fri, 21 Aug 2020 19:44:45 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9Cxd-0006UA-0u for linux-arm-kernel@lists.infradead.org; Fri, 21 Aug 2020 19:44:28 +0000 Received: by mail-pg1-x542.google.com with SMTP id s15so1467061pgc.8 for ; Fri, 21 Aug 2020 12:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=A9ju+r34sWfhod71XL1bT+zi6vF+Wn+whGvig44U/H8=; b=mPcfZIGuf1IZHjreJOKyf+8HKo4m4M4Fs7OCfWzQHGepGQ2VKw/pZolBRvYuRnsgrD iO6Sm/0z9adI7m403A/1my//6tCmpz/F5LGl8FcvQXkQNaGnonYynUO4LclCHmwMJqs0 O0N8myI4UIrjk5XmzJuV30avHlcvBnyogqviE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=A9ju+r34sWfhod71XL1bT+zi6vF+Wn+whGvig44U/H8=; b=q+WAsuIJT6keN2aVByYws1NiRz+1nX9XaGJ3m7lxYP3CzPJQDf6EkleopUJXAaxjwK glIieMYjpnqDPHnBqIfQ/yUxLq2X4MAokDLXWn052hMnHwrCLr+OKnrRArGxb4mEPKmP twjOUgtLNkstvV7h4YvKjaACRdNps7PKw1g290/DgjB2A5rS/5oe0UB7J19sHkVCytsp VMkwX4FNsjlfKRDweVjvA6de3ugQel99lwmTMGu0ar9UfxfMPDej1x7f3WP29xnsetGK sLtkk9lVb6qcSQ/I1bGGTakLEu6DpckyOgP7aOfXKPJXS+qfPObqszm3VBmvTnkbPFFX hX2A== X-Gm-Message-State: AOAM530dTnjodqfswg0GLrbV+Owr/jjlHJKDfYA9A34oPM4yD1qPSP6o ANeu06e7M1JsFJNveklopYwwaw== X-Google-Smtp-Source: ABdhPJxNUi6ggriXccpA572qG6bm/FjMSOm/9dg/71/aIV6K+hAYLL89xzLCOF1RLAPDkBnD4lQ2Ag== X-Received: by 2002:aa7:8bd2:: with SMTP id s18mr3530477pfd.284.1598039062849; Fri, 21 Aug 2020 12:44:22 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y28sm3504632pfq.83.2020.08.21.12.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2020 12:44:21 -0700 (PDT) From: Kees Cook To: Ingo Molnar Subject: [PATCH v6 02/29] vmlinux.lds.h: Add .gnu.version* to COMMON_DISCARDS Date: Fri, 21 Aug 2020 12:42:43 -0700 Message-Id: <20200821194310.3089815-3-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200821194310.3089815-1-keescook@chromium.org> References: <20200821194310.3089815-1-keescook@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200821_154425_124205_93C2278A X-CRM114-Status: GOOD ( 16.10 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:542 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, Kees Cook , Fangrui Song , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Arvind Sankar , Ingo Molnar , James Morse , linux-arm-kernel@lists.infradead.org, Nathan Chancellor , Borislav Petkov , Peter Collingbourne , Ard Biesheuvel , Arnd Bergmann Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org For vmlinux linking, no architecture uses the .gnu.version* sections, so remove it via the COMMON_DISCARDS macro in preparation for adding --orphan-handling=warn more widely. This is a work-around for what appears to be a bug[1] in ld.bfd which warns for this synthetic section even when none is found in input objects, and even when no section is emitted for an output object[2]. [1] https://sourceware.org/bugzilla/show_bug.cgi?id=26153 [2] https://lore.kernel.org/lkml/202006221524.CEB86E036B@keescook/ Reviewed-by: Fangrui Song Signed-off-by: Kees Cook --- include/asm-generic/vmlinux.lds.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index 184b23d62784..f1f02a2f71b7 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -957,7 +957,9 @@ #define COMMON_DISCARDS \ *(.discard) \ *(.discard.*) \ - *(.modinfo) + *(.modinfo) \ + /* ld.bfd warns about .gnu.version* even when not emitted */ \ + *(.gnu.version*) \ #define DISCARDS \ /DISCARD/ : { \