| Message ID | 20200825114403.1392369-1-yukuai3@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/sun4i: add missing put_device() call in sun8i_r40_tcon_tv_set_mux() | expand |
Hi, On Tue, Aug 25, 2020 at 07:44:03PM +0800, Yu Kuai wrote: > If sun8i_r40_tcon_tv_set_mux() succeed, at_dma_xlate() doesn't have a > corresponding put_device(). Thus add put_device() to fix the exception > handling for this function implementation. > > Fixes: 0305189afb32 ("drm/sun4i: tcon: Add support for R40 TCON") > Signed-off-by: Yu Kuai <yukuai3@huawei.com> That doesn't sound right, we're not using at_dma_xlate at all in that driver? Maxime
On 2020/08/25 21:38, Maxime Ripard wrote: > Hi, > > On Tue, Aug 25, 2020 at 07:44:03PM +0800, Yu Kuai wrote: >> If sun8i_r40_tcon_tv_set_mux() succeed, at_dma_xlate() doesn't have a >> corresponding put_device(). Thus add put_device() to fix the exception >> handling for this function implementation. >> >> Fixes: 0305189afb32 ("drm/sun4i: tcon: Add support for R40 TCON") >> Signed-off-by: Yu Kuai <yukuai3@huawei.com> > > That doesn't sound right, we're not using at_dma_xlate at all in that > driver? > Hi! sry about that, should be sun8i_r40_tcon_tv_set_mux(), same as the title said. Best regards, Yu Kuai
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index ced9a8287dd8..e40c542254f6 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c @@ -1433,14 +1433,18 @@ static int sun8i_r40_tcon_tv_set_mux(struct sun4i_tcon *tcon, if (IS_ENABLED(CONFIG_DRM_SUN8I_TCON_TOP) && encoder->encoder_type == DRM_MODE_ENCODER_TMDS) { ret = sun8i_tcon_top_set_hdmi_src(&pdev->dev, id); - if (ret) + if (ret) { + put_device(&pdev->dev); return ret; + } } if (IS_ENABLED(CONFIG_DRM_SUN8I_TCON_TOP)) { ret = sun8i_tcon_top_de_config(&pdev->dev, tcon->id, id); - if (ret) + if (ret) { + put_device(&pdev->dev); return ret; + } } return 0;
If sun8i_r40_tcon_tv_set_mux() succeed, at_dma_xlate() doesn't have a corresponding put_device(). Thus add put_device() to fix the exception handling for this function implementation. Fixes: 0305189afb32 ("drm/sun4i: tcon: Add support for R40 TCON") Signed-off-by: Yu Kuai <yukuai3@huawei.com> --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)