| Message ID | 20200826035430.21060-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] irqchip/ti-sci-inta: Fix unsigned comparison to zero | expand |
On 26/08/20 9:24 am, YueHaibing wrote: > ti_sci_inta_xlate_irq() return -ENOENT on fail, p_hwirq > should be int type. > > Fixes: 5c4b585d2910 ("irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Lokesh Vutla <lokeshvutla@ti.com> Thanks and regards, Lokesh
On Wed, 26 Aug 2020 11:54:30 +0800, YueHaibing wrote: > ti_sci_inta_xlate_irq() return -ENOENT on fail, p_hwirq > should be int type. Applied to irq/irqchip-fixes-5.9, thanks! [1/1] irqchip/ti-sci-inta: Fix unsigned comparison to zero commit: 4c9b1bfaa5039fee650f4de514a8e70ae976fc2f Cheers, M.
diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c index d4e97605456b..05bf94b87b93 100644 --- a/drivers/irqchip/irq-ti-sci-inta.c +++ b/drivers/irqchip/irq-ti-sci-inta.c @@ -175,8 +175,8 @@ static struct ti_sci_inta_vint_desc *ti_sci_inta_alloc_parent_irq(struct irq_dom struct irq_fwspec parent_fwspec; struct device_node *parent_node; unsigned int parent_virq; - u16 vint_id, p_hwirq; - int ret; + int p_hwirq, ret; + u16 vint_id; vint_id = ti_sci_get_free_resource(inta->vint); if (vint_id == TI_SCI_RESOURCE_NULL)
ti_sci_inta_xlate_irq() return -ENOENT on fail, p_hwirq should be int type. Fixes: 5c4b585d2910 ("irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/irqchip/irq-ti-sci-inta.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)