| Message ID | 20200826131637.421327-1-tomi.valkeinen@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] arm64: dts: ti: k3-am65: mark dss as dma-coherent | expand |
On 16:16-20200826, Tomi Valkeinen wrote: > DSS is IO coherent on AM65, so we can mark it as such with > 'dma-coherent' property in the DT file. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > index 9edfae5944f7..efd3f18f4be3 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > @@ -847,6 +847,8 @@ dss: dss@04a00000 { > > status = "disabled"; > > + dma-coherent; > + > dss_ports: ports { > #address-cells = <1>; > #size-cells = <0>; Could you look closer at the dss node a bit? dtbs_check results in a change in error (on next-20200824): -/workdir/arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml: dss@04a00000: 'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+' +/workdir/arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml: dss@04a00000: 'assigned-clock-parents', 'assigned-clocks', 'dma-coherent' do not match any of the regexes: 'pinctrl-[0-9]+' I am not sure what extent is the dss conversion to yaml done.
Hi Nishanth, On 27/08/2020 03:13, Nishanth Menon wrote: > On 16:16-20200826, Tomi Valkeinen wrote: >> DSS is IO coherent on AM65, so we can mark it as such with >> 'dma-coherent' property in the DT file. >> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >> index 9edfae5944f7..efd3f18f4be3 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >> @@ -847,6 +847,8 @@ dss: dss@04a00000 { >> >> status = "disabled"; >> >> + dma-coherent; >> + >> dss_ports: ports { >> #address-cells = <1>; >> #size-cells = <0>; > Could you look closer at the dss node a bit? dtbs_check results in a > change in error (on next-20200824): > -/workdir/arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml: dss@04a00000: 'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+' > +/workdir/arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml: dss@04a00000: 'assigned-clock-parents', 'assigned-clocks', 'dma-coherent' do not match any of the regexes: 'pinctrl-[0-9]+' > > I am not sure what extent is the dss conversion to yaml done. I sent a v2, with two new patches to extend the schema to cover those properties. Tomi
diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi index 9edfae5944f7..efd3f18f4be3 100644 --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi @@ -847,6 +847,8 @@ dss: dss@04a00000 { status = "disabled"; + dma-coherent; + dss_ports: ports { #address-cells = <1>; #size-cells = <0>;
DSS is IO coherent on AM65, so we can mark it as such with 'dma-coherent' property in the DT file. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 ++ 1 file changed, 2 insertions(+)