From patchwork Wed Sep 2 02:53:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 11749655 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7A069618 for ; Wed, 2 Sep 2020 02:54:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 530FC206CD for ; Wed, 2 Sep 2020 02:54:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bxuqNnkS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FwZ8Z44S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 530FC206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XWirrUFG3JqJOjJBL5ebHp5rwj5wVqJO1co4gRAaxMQ=; b=bxuqNnkSRC1SpTZBXwhpfXdmu Tlm6rZoy8UEEQqUP7hzK0s7Xa1R/9sErWGh/3a6wEY7DYmn4Mx/d01SvGa8/bsc6N0cjHEuVNL4oF EQQ890SssbbtgxAVOICdy1PX2we2GOFzMBEpzRfPF/FmiKJ/43RUxV1iqxR8okc1N5br7KVHp4Y0v yvwAkIMp4P7JBqupIX9d/lahR6GUQsZQAPrGSZH1/G62JWQ5q2qQpvYT8xB2BQ+ASuXGfNSoPUdyX SSMD/xgikSx9nEem3f90bjKcCO/lEsYu64KA2AIlNOa9nFE4r8wFxutNs/fPBtUEisKqPNiHbLN1K Q2KGKSmfw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuY-0003bi-NK; Wed, 02 Sep 2020 02:54:10 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuK-0003Vr-PG for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 02:54:00 +0000 Received: by mail-pf1-x441.google.com with SMTP id f18so2014165pfa.10 for ; Tue, 01 Sep 2020 19:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bSRmKV4TxKCXU40IBJQsfTYjUw2udm0vFSvEERZRBX0=; b=FwZ8Z44SN7D4KRJA4npu9mvkVI0wXuCLYH1l2mLJj8aelE0Rk0L2zjDZgtqEkgrGP5 Vdlh91A3FK9cW00PtADerkvJE2DbDmOjQwdEO6PDh5uBo9JY+jiyUUcP5hnU8Rb7ZGKm uWPcKxWzPxVjBdhDrkoEXl9Yq9bB3c9PCSDYE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bSRmKV4TxKCXU40IBJQsfTYjUw2udm0vFSvEERZRBX0=; b=RIoUO5R2VC1nWupQck4f5ltOijTq2BLGvY8/4UqxPCIQF3Mkj8osIFhHGJYFLD7Cii Koww6+LdjT/gsj1DNRGuFunhOolMxH59C66KsHG5faJBCuEZu3GGJB3oxSTDnqu0jp32 arE181dsYsK4Gys1MTQik4WxS5DFAm6ZREcF+EZIRgplOEo8xqlRc0AWEAhOvtjzQrot Xba4/78hw4YE57zk2eIFDOeQuArPoWN29c9rzACJXlbc/3QboPo1gUfVjZPeidZJv5OC pJAwR4IY3TOFOUnOW7rJyxlrDrpXHyULk1p9IERsIMv8KBiLcPeKELFgBuz7jrOoXxpD Qaew== X-Gm-Message-State: AOAM533zfZavhx8xzq0ZKttZYN+cIwyxAWrjVIE4FLMGSJ3riKERkDn2 DSD7fpqDs3nBfXUImOYss0rYIQ== X-Google-Smtp-Source: ABdhPJwGPpNyETRl4VuDPYZiIlH2eDa0br1azIegj/wzZtKCn4U41u9SncizzsUSeepmeQxRgh8NDQ== X-Received: by 2002:aa7:824a:: with SMTP id e10mr1243727pfn.62.1599015234783; Tue, 01 Sep 2020 19:53:54 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 31sm2560666pgo.17.2020.09.01.19.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 19:53:50 -0700 (PDT) From: Kees Cook To: Ingo Molnar Subject: [PATCH v7 4/5] x86/build: Warn on orphan section placement Date: Tue, 1 Sep 2020 19:53:46 -0700 Message-Id: <20200902025347.2504702-5-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902025347.2504702-1-keescook@chromium.org> References: <20200902025347.2504702-1-keescook@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_225356_859609_0A8AE84C X-CRM114-Status: GOOD ( 12.89 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, Kees Cook , Arnd Bergmann , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Arvind Sankar , Ingo Molnar , James Morse , Nathan Chancellor , Borislav Petkov , Peter Collingbourne , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly handled in the linker script. Now that all sections are explicitly handled, enable orphan section warnings. Signed-off-by: Kees Cook --- arch/x86/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/x86/Makefile b/arch/x86/Makefile index 4346ffb2e39f..154259f18b8b 100644 --- a/arch/x86/Makefile +++ b/arch/x86/Makefile @@ -209,6 +209,10 @@ ifdef CONFIG_X86_64 LDFLAGS_vmlinux += -z max-page-size=0x200000 endif +# We never want expected sections to be placed heuristically by the +# linker. All sections should be explicitly named in the linker script. +LDFLAGS_vmlinux += $(call ld-option, --orphan-handling=warn) + archscripts: scripts_basic $(Q)$(MAKE) $(build)=arch/x86/tools relocs