From patchwork Wed Sep 2 02:53:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 11749661 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BC81D1575 for ; Wed, 2 Sep 2020 02:55:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96544206CD for ; Wed, 2 Sep 2020 02:55:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GlxZuQ+z"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bNeNVIUp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96544206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RYMNOIJMv+ye/D9c1q1Smt+RWd5DNh0E7q7Hwkim/d0=; b=GlxZuQ+zEpis4Rz9jNhW1V6/O A7TLrAis5Gcjapj6K1L5sLBHckG394n+GOmR4KEAu/XLSfEc9hbKO8eZ2K+WFBJCusHr6A6a3Flkn 43I89V8hwfYrwJUO0vfp22+OSy+EBRvMmzWDwgBjwAPk+H8Q9KzHI9De+5HZNVUyIQypAatdPj+TW /AhG0773cyZK80J5/PkvhsHcMUPIivyUG8zhm1DNdU/D74PREdn4E4WjSk078l8nQyhAFcS/Gf+vA 129zU3VwLborMbqW7Fp7ywrVmOxns5rQAaHwGtZXyGwIbr1Jd5cOkMvxmgViDy6c34WBy2YpvXwJG FdF3Lp+JA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuX-0003bG-54; Wed, 02 Sep 2020 02:54:09 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuM-0003XQ-5A for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 02:54:00 +0000 Received: by mail-pg1-x544.google.com with SMTP id d19so1781347pgl.10 for ; Tue, 01 Sep 2020 19:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JcvEo160LuHDQD7qfOvAP7KcCyAU7p1FFARh/mGAmoY=; b=bNeNVIUp5wLd20zY7GcMyTGEK+1iPazVe7pNUjLaD0gXYItCy+3Sdv//WvvNwoKDM6 Uv+a9vaUg3+t1WxF84thK1gkM5sHMKI+Rq2tNAhA7rAZnF0RzdZRMP6vmNwRs2hT7jbC A2ZuOezSk/Jtm5d8lXaE6Ct1Du9kbe7yDRf6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JcvEo160LuHDQD7qfOvAP7KcCyAU7p1FFARh/mGAmoY=; b=UrCH1lwQVl4yLY9dul684d8ZR/P8T9YRRJluvGkxAzRhfIUKe1W9nKw2VAEFTSdhw+ B7dLCd1v/X1mwXBPZF4cENdb2mhmskR9lNkH8B1kQoGphjKVFQ4Vovm84HoVIGGyDRsd 6A5I49aqkaimHQ8pgaHRBMxQMg5tbFIuoib/N0eq1gEEkADdg8+EcCxpNi426DpwNi6z jIlycKoRlzaUamDyqhDoiY6IaL1+JNFZyyInqHbpyRRWRbOdkTedfXmcVBtg6152eHW8 6y2LglIwCdJRmjRe1FNTLAACO38Ur7BhRDX4fkSMSRk9cotjfIl8I2QAcOq2R9wgolDT km0g== X-Gm-Message-State: AOAM532qt4GtTDm7jyQgx3EMeBY8wl9lyVuT6NqFJL1n/uKEKg2Ziucb qWI6u+JPCe5DOTKWD6u36chfUw== X-Google-Smtp-Source: ABdhPJy0HGMfDCWkJW2ahd3RYXmS5RA7xjHg6pHP5/RCgQANMg7x7X7wDQT+vfbBEud/U6454iTChQ== X-Received: by 2002:a63:d34e:: with SMTP id u14mr235066pgi.122.1599015236142; Tue, 01 Sep 2020 19:53:56 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o192sm3673517pfg.81.2020.09.01.19.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 19:53:54 -0700 (PDT) From: Kees Cook To: Ingo Molnar Subject: [PATCH v7 5/5] x86/boot/compressed: Warn on orphan section placement Date: Tue, 1 Sep 2020 19:53:47 -0700 Message-Id: <20200902025347.2504702-6-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902025347.2504702-1-keescook@chromium.org> References: <20200902025347.2504702-1-keescook@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_225358_341318_74F15FFE X-CRM114-Status: GOOD ( 14.86 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:544 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, Kees Cook , Arnd Bergmann , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Arvind Sankar , Ingo Molnar , James Morse , Nathan Chancellor , Borislav Petkov , Peter Collingbourne , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly handled in the linker script. Now that all sections are explicitly handled, enable orphan section warnings. Signed-off-by: Kees Cook --- arch/x86/boot/compressed/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile index 5b7f6e175b03..871cc071c925 100644 --- a/arch/x86/boot/compressed/Makefile +++ b/arch/x86/boot/compressed/Makefile @@ -54,6 +54,7 @@ KBUILD_LDFLAGS += $(call ld-option,--no-ld-generated-unwind-info) # Compressed kernel should be built as PIE since it may be loaded at any # address by the bootloader. LDFLAGS_vmlinux := -pie $(call ld-option, --no-dynamic-linker) +LDFLAGS_vmlinux += $(call ld-option, --orphan-handling=warn) LDFLAGS_vmlinux += -T hostprogs := mkpiggy