diff mbox series

PCI: xilinx-cpm: Remove leftover bridge initialization

Message ID 20200904142710.8018-1-lorenzo.pieralisi@arm.com (mailing list archive)
State New, archived
Headers show
Series PCI: xilinx-cpm: Remove leftover bridge initialization | expand

Commit Message

Lorenzo Pieralisi Sept. 4, 2020, 2:27 p.m. UTC
Some fields in the host bridge structure are now initialized
by default in the PCI/OF core functions therefore their
initialization in the host controller driver is superfluous.

Remove it.

Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Rob Herring <robh@kernel.org>
---
 drivers/pci/controller/pcie-xilinx-cpm.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Rob Herring Sept. 4, 2020, 7:10 p.m. UTC | #1
On Fri, Sep 4, 2020 at 8:27 AM Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> Some fields in the host bridge structure are now initialized
> by default in the PCI/OF core functions therefore their
> initialization in the host controller driver is superfluous.
>
> Remove it.
>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Rob Herring <robh@kernel.org>
> ---
>  drivers/pci/controller/pcie-xilinx-cpm.c | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/drivers/pci/controller/pcie-xilinx-cpm.c b/drivers/pci/controller/pcie-xilinx-cpm.c
index f3082de44e8a..f92e0152e65e 100644
--- a/drivers/pci/controller/pcie-xilinx-cpm.c
+++ b/drivers/pci/controller/pcie-xilinx-cpm.c
@@ -572,12 +572,8 @@  static int xilinx_cpm_pcie_probe(struct platform_device *pdev)
 		goto err_setup_irq;
 	}
 
-	bridge->dev.parent = dev;
 	bridge->sysdata = port->cfg;
-	bridge->busnr = port->cfg->busr.start;
 	bridge->ops = (struct pci_ops *)&pci_generic_ecam_ops.pci_ops;
-	bridge->map_irq = of_irq_parse_and_map_pci;
-	bridge->swizzle_irq = pci_common_swizzle;
 
 	err = pci_host_probe(bridge);
 	if (err < 0)