From patchwork Mon Sep 7 21:17:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 11762267 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E7A3959D for ; Mon, 7 Sep 2020 21:19:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3205217A0 for ; Mon, 7 Sep 2020 21:19:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LoxNstOD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="HwtzBBMa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3205217A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alliedtelesis.co.nz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MWllngNgaV2DTPsGHfgVhkxg3qJRV8K7ViYp+PnqcGo=; b=LoxNstODT+1EhuD0BH5V3+wol taB3qRsglyb5Yiemi6RjccvEyfG0m1mT63QZeLs2GwcT8ldmwdmY0xosS/LHR6JILJ+yVA2P8FOaA Vv4RMO7EqLMakWWJLBf8Vvk/DIBQ2cqyXujnhxtHdVIk0caLEuNnJR2j/TmkkShtnLdl2ACfWJ3wb AvHndyxjxFYwOGFzDCuAkvzjt35MCoSldfUxw0DWL/Pfzoa0kchPk23ukKtSBoyYkgE7LPMIpbbBA /KKfUAciaKNqrRPD03E5gKEIBbb777YA4iGGlnrol2hfa6zFoAyuzPi2rog4eo+ZzIWn8xwFlssAj GaoUt7okw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFOWL-00020q-5s; Mon, 07 Sep 2020 21:17:49 +0000 Received: from gate2.alliedtelesis.co.nz ([2001:df5:b000:5::4]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFOVt-0001u5-FH for linux-arm-kernel@lists.infradead.org; Mon, 07 Sep 2020 21:17:24 +0000 Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id EE21F84487; Tue, 8 Sep 2020 09:17:16 +1200 (NZST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1599513436; bh=xyKdSvt7aRQjiRwwyViq5z2f31mBwmO25H0wKpZA36A=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HwtzBBMaDrkLngD+xsNItqAIBhlmSILax+6grhZumZm6wrb12tncOueiITHcJ7IWk gZ9DblbvFsdVX5WMIabz+bq51v1PtcZ81PFx73rLIJNTorBCKxz4p5740SxDH4H3A7 BE3O4SonEGLKF+pp0uY8O0W7gs9CWYA50G/x0NoHYValdCjvgWww5X2w8XsU+YipCV 6ncdWjD1yv3ptUQAsyiWC/OO8cmsJ42pueh1E9A4rOaxV5wqaSnH2fZp1VpwMQJfs4 IQpHvPpr07uo1fkAokxkNJ+ugXPLdYyTGw2EOerd0S8IQND2jCGWVU1aj/ANyNi9/9 R763NKAeUrZ/A== Received: from smtp (Not Verified[10.32.16.33]) by mmarshal3.atlnz.lc with Trustwave SEG (v7, 5, 8, 10121) id ; Tue, 08 Sep 2020 09:17:16 +1200 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.20]) by smtp (Postfix) with ESMTP id 695B113EED0; Tue, 8 Sep 2020 09:17:15 +1200 (NZST) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 1BDCE280060; Tue, 8 Sep 2020 09:17:16 +1200 (NZST) From: Chris Packham To: jason@lakedaemon.net, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, robh+dt@kernel.org, linus.walleij@linaro.org Subject: [PATCH v2 1/3] pinctrl: mvebu: Fix i2c sda definition for 98DX3236 Date: Tue, 8 Sep 2020 09:17:10 +1200 Message-Id: <20200907211712.9697-2-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200907211712.9697-1-chris.packham@alliedtelesis.co.nz> References: <20200907211712.9697-1-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 x-atlnz-ls: pat X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_171722_344025_26565AAC X-CRM114-Status: GOOD ( 19.70 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Kalyan Kinthada , Chris Packham , Rob Herring , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Per the datasheet the i2c functions use MPP_Sel=0x1. They are documented as using MPP_Sel=0x4 as well but mixing 0x1 and 0x4 is clearly wrong. On the board tested 0x4 resulted in a non-functioning i2c bus so stick with 0x1 which works. Fixes: d7ae8f8dee7f ("pinctrl: mvebu: pinctrl driver for 98DX3236 SoC") Signed-off-by: Chris Packham Reviewed-by: Andrew Lunn --- Changes in v2: - Add reviewed-by from Andrew drivers/pinctrl/mvebu/pinctrl-armada-xp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-xp.c b/drivers/pinctrl/mvebu/pinctrl-armada-xp.c index a767a05fa3a0..48e2a6c56a83 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-xp.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-xp.c @@ -414,7 +414,7 @@ static struct mvebu_mpp_mode mv98dx3236_mpp_modes[] = { MPP_VAR_FUNCTION(0x1, "i2c0", "sck", V_98DX3236_PLUS)), MPP_MODE(15, MPP_VAR_FUNCTION(0x0, "gpio", NULL, V_98DX3236_PLUS), - MPP_VAR_FUNCTION(0x4, "i2c0", "sda", V_98DX3236_PLUS)), + MPP_VAR_FUNCTION(0x1, "i2c0", "sda", V_98DX3236_PLUS)), MPP_MODE(16, MPP_VAR_FUNCTION(0x0, "gpo", NULL, V_98DX3236_PLUS), MPP_VAR_FUNCTION(0x4, "dev", "oe", V_98DX3236_PLUS)),