| Message ID | 20200910140415.1132266-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: fsl: dpio: remove set but not used 'addr_cena' | expand |
On Thu, 10 Sep 2020 at 16:57, Jason Yan <yanaijie@huawei.com> wrote: > > This addresses the following gcc warning with "make W=1": > > drivers/soc/fsl/dpio/qbman-portal.c: In function > ‘qbman_swp_enqueue_multiple_direct’: > drivers/soc/fsl/dpio/qbman-portal.c:650:11: warning: variable > ‘addr_cena’ set but not used [-Wunused-but-set-variable] > 650 | uint64_t addr_cena; > | ^~~~~~~~~ > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Jason Yan <yanaijie@huawei.com> This was already reported: Reported-by: kernel test robot <lkp@intel.com> https://lkml.org/lkml/2020/6/12/290 Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof > --- > drivers/soc/fsl/dpio/qbman-portal.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/soc/fsl/dpio/qbman-portal.c b/drivers/soc/fsl/dpio/qbman-portal.c > index 0ab85bfb116f..659b4a570d5b 100644 > --- a/drivers/soc/fsl/dpio/qbman-portal.c > +++ b/drivers/soc/fsl/dpio/qbman-portal.c > @@ -647,7 +647,6 @@ int qbman_swp_enqueue_multiple_direct(struct qbman_swp *s, > const uint32_t *cl = (uint32_t *)d; > uint32_t eqcr_ci, eqcr_pi, half_mask, full_mask; > int i, num_enqueued = 0; > - uint64_t addr_cena; > > spin_lock(&s->access_spinlock); > half_mask = (s->eqcr.pi_ci_mask>>1); > @@ -701,7 +700,6 @@ int qbman_swp_enqueue_multiple_direct(struct qbman_swp *s, > > /* Flush all the cacheline without load/store in between */ > eqcr_pi = s->eqcr.pi; > - addr_cena = (size_t)s->addr_cena; > for (i = 0; i < num_enqueued; i++) > eqcr_pi++; > s->eqcr.pi = eqcr_pi & full_mask; > -- > 2.25.4 >
On Sun, Sep 20, 2020 at 3:20 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Thu, 10 Sep 2020 at 16:57, Jason Yan <yanaijie@huawei.com> wrote: > > > > This addresses the following gcc warning with "make W=1": > > > > drivers/soc/fsl/dpio/qbman-portal.c: In function > > ‘qbman_swp_enqueue_multiple_direct’: > > drivers/soc/fsl/dpio/qbman-portal.c:650:11: warning: variable > > ‘addr_cena’ set but not used [-Wunused-but-set-variable] > > 650 | uint64_t addr_cena; > > | ^~~~~~~~~ > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: Jason Yan <yanaijie@huawei.com> > > This was already reported: > Reported-by: kernel test robot <lkp@intel.com> > https://lkml.org/lkml/2020/6/12/290 > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Applied for next. Thanks. > > Best regards, > Krzysztof > > > --- > > drivers/soc/fsl/dpio/qbman-portal.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/soc/fsl/dpio/qbman-portal.c b/drivers/soc/fsl/dpio/qbman-portal.c > > index 0ab85bfb116f..659b4a570d5b 100644 > > --- a/drivers/soc/fsl/dpio/qbman-portal.c > > +++ b/drivers/soc/fsl/dpio/qbman-portal.c > > @@ -647,7 +647,6 @@ int qbman_swp_enqueue_multiple_direct(struct qbman_swp *s, > > const uint32_t *cl = (uint32_t *)d; > > uint32_t eqcr_ci, eqcr_pi, half_mask, full_mask; > > int i, num_enqueued = 0; > > - uint64_t addr_cena; > > > > spin_lock(&s->access_spinlock); > > half_mask = (s->eqcr.pi_ci_mask>>1); > > @@ -701,7 +700,6 @@ int qbman_swp_enqueue_multiple_direct(struct qbman_swp *s, > > > > /* Flush all the cacheline without load/store in between */ > > eqcr_pi = s->eqcr.pi; > > - addr_cena = (size_t)s->addr_cena; > > for (i = 0; i < num_enqueued; i++) > > eqcr_pi++; > > s->eqcr.pi = eqcr_pi & full_mask; > > -- > > 2.25.4 > >
diff --git a/drivers/soc/fsl/dpio/qbman-portal.c b/drivers/soc/fsl/dpio/qbman-portal.c index 0ab85bfb116f..659b4a570d5b 100644 --- a/drivers/soc/fsl/dpio/qbman-portal.c +++ b/drivers/soc/fsl/dpio/qbman-portal.c @@ -647,7 +647,6 @@ int qbman_swp_enqueue_multiple_direct(struct qbman_swp *s, const uint32_t *cl = (uint32_t *)d; uint32_t eqcr_ci, eqcr_pi, half_mask, full_mask; int i, num_enqueued = 0; - uint64_t addr_cena; spin_lock(&s->access_spinlock); half_mask = (s->eqcr.pi_ci_mask>>1); @@ -701,7 +700,6 @@ int qbman_swp_enqueue_multiple_direct(struct qbman_swp *s, /* Flush all the cacheline without load/store in between */ eqcr_pi = s->eqcr.pi; - addr_cena = (size_t)s->addr_cena; for (i = 0; i < num_enqueued; i++) eqcr_pi++; s->eqcr.pi = eqcr_pi & full_mask;
This addresses the following gcc warning with "make W=1": drivers/soc/fsl/dpio/qbman-portal.c: In function ‘qbman_swp_enqueue_multiple_direct’: drivers/soc/fsl/dpio/qbman-portal.c:650:11: warning: variable ‘addr_cena’ set but not used [-Wunused-but-set-variable] 650 | uint64_t addr_cena; | ^~~~~~~~~ Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/soc/fsl/dpio/qbman-portal.c | 2 -- 1 file changed, 2 deletions(-)