| Message ID | 20200912125148.1271481-6-maz@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | irqchip: Hybrid probing | expand |
On Sat 12 Sep 07:51 CDT 2020, Marc Zyngier wrote: > Switch the driver to a "hybrid probe" model which preserves the > built-in behaviour while allowing the driver to be optionnally > built as a module for development purposes. > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Marc Zyngier <maz@kernel.org> > --- > drivers/irqchip/irq-mtk-sysirq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c > index 6ff98b87e5c0..ee45d8f71ec3 100644 > --- a/drivers/irqchip/irq-mtk-sysirq.c > +++ b/drivers/irqchip/irq-mtk-sysirq.c > @@ -231,4 +231,6 @@ static int __init mtk_sysirq_of_init(struct device_node *node, > kfree(chip_data); > return ret; > } > -IRQCHIP_DECLARE(mtk_sysirq, "mediatek,mt6577-sysirq", mtk_sysirq_of_init); > +IRQCHIP_HYBRID_DRIVER_BEGIN(mtk_sysirq) > +IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init) > +IRQCHIP_HYBRID_DRIVER_END(mtk_sysirq) > -- > 2.28.0 >
Missatge de Bjorn Andersson <bjorn.andersson@linaro.org> del dia dg., 13 de set. 2020 a les 1:25: > > On Sat 12 Sep 07:51 CDT 2020, Marc Zyngier wrote: > > > Switch the driver to a "hybrid probe" model which preserves the > > built-in behaviour while allowing the driver to be optionnally > > built as a module for development purposes. > > > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > > Signed-off-by: Marc Zyngier <maz@kernel.org> I've tested this on mt8173 and mt8183, and this time, the patches didn't break booting on these platforms. For MediaTek, right now, only makes sense the driver to be built-in as other drivers that use it are not ready for deferring their probe. So, Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Thanks Enric > > --- > > drivers/irqchip/irq-mtk-sysirq.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c > > index 6ff98b87e5c0..ee45d8f71ec3 100644 > > --- a/drivers/irqchip/irq-mtk-sysirq.c > > +++ b/drivers/irqchip/irq-mtk-sysirq.c > > @@ -231,4 +231,6 @@ static int __init mtk_sysirq_of_init(struct device_node *node, > > kfree(chip_data); > > return ret; > > } > > -IRQCHIP_DECLARE(mtk_sysirq, "mediatek,mt6577-sysirq", mtk_sysirq_of_init); > > +IRQCHIP_HYBRID_DRIVER_BEGIN(mtk_sysirq) > > +IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init) > > +IRQCHIP_HYBRID_DRIVER_END(mtk_sysirq) > > -- > > 2.28.0 > >
diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c index 6ff98b87e5c0..ee45d8f71ec3 100644 --- a/drivers/irqchip/irq-mtk-sysirq.c +++ b/drivers/irqchip/irq-mtk-sysirq.c @@ -231,4 +231,6 @@ static int __init mtk_sysirq_of_init(struct device_node *node, kfree(chip_data); return ret; } -IRQCHIP_DECLARE(mtk_sysirq, "mediatek,mt6577-sysirq", mtk_sysirq_of_init); +IRQCHIP_HYBRID_DRIVER_BEGIN(mtk_sysirq) +IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init) +IRQCHIP_HYBRID_DRIVER_END(mtk_sysirq)
Switch the driver to a "hybrid probe" model which preserves the built-in behaviour while allowing the driver to be optionnally built as a module for development purposes. Signed-off-by: Marc Zyngier <maz@kernel.org> --- drivers/irqchip/irq-mtk-sysirq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)