| Message ID | 20200915140141.42876-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] clk: imx35: Make mx35_clocks_init static | expand |
Hi YueHaibing, On Tue, Sep 15, 2020 at 11:02 AM YueHaibing <yuehaibing@huawei.com> wrote: > > Fix sparse warning: > > drivers/clk/imx/clk-imx35.c:251:12: warning: > symbol 'mx35_clocks_init' was not declared. Should it be static? This is not the correct fix. mx35_clocks_init() was only used by imx35 board files. Now that imx35 board files are gone, this function can be removed. I will send a patch removing it.
diff --git a/drivers/clk/imx/clk-imx35.c b/drivers/clk/imx/clk-imx35.c index e595f559907f..2594f41d0980 100644 --- a/drivers/clk/imx/clk-imx35.c +++ b/drivers/clk/imx/clk-imx35.c @@ -248,7 +248,7 @@ static void __init _mx35_clocks_init(void) imx_print_silicon_rev("i.MX35", mx35_revision()); } -int __init mx35_clocks_init(void) +static int __init mx35_clocks_init(void) { _mx35_clocks_init();
Fix sparse warning: drivers/clk/imx/clk-imx35.c:251:12: warning: symbol 'mx35_clocks_init' was not declared. Should it be static? Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/clk/imx/clk-imx35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)