From patchwork Mon Sep 21 07:49:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 11788641 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C19716CA for ; Mon, 21 Sep 2020 07:51:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9379F20874 for ; Mon, 21 Sep 2020 07:51:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oqURS58e"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="zluKvCTL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9379F20874 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=6oLWVW/ii5nzlsXdKb9LneIAG1N239hTEA3HAXviNOw=; b=oqURS58eriVwQuqULHWuF5YBOb mQiodZxApoV1zxahOPzkqSeE12WI/HT7Wg31KHmcan145c7VyhmzrCdhynvS5XsSv9b/brdDN4NHw PXKum2w2UPrMAGQOqG2u2Bauis5iAPaJEDy11drs60bkyYsVMrHeYA0WtvwCKJa+DTbeZi77Nkql/ 4e+ALWcGuAVuQYiNNWa4O04DqV5r607RgtoErLRvfPX5ujS0wS3O8kHYXqFav9rwdgyyDVLh6HB5V DjdxVl5XvBE7s3vGZvGEpE2flOs4etxYb29pjyHOIohPGZKyblalSf3//w7jxtJFvIMkQ9HuTIWxn +eerR8wA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKGaL-0000MW-I1; Mon, 21 Sep 2020 07:50:05 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKGaH-0000L0-ME for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2020 07:50:03 +0000 Received: by mail-wm1-x342.google.com with SMTP id q9so11124380wmj.2 for ; Mon, 21 Sep 2020 00:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eQeugMSbNm4MoGJLzLTQ1K90HqMCkQsDeLBTGL4VkMo=; b=zluKvCTLGO4Q1xNTMRSk0CyQwXbjLielLIiaHrs4aJ5B23YEK6UYXhfPZMmf68MMOU iXyvqIhrO/BHAKZf7qyHRQtoTetEsfzpsvASAnylyINqR4S2WdmLE/h6s8/Jnuk2wjJR fEPUhakN0RlOs2+ggSV6P5Xy7mjIdLSYAC+40Ghdh0WnDP2O+E85ah/3weYMe56st1sT L961A5Y/17Ncdz8TwYz8QJjIUHfR+8nMcSlRIUnr7CmhLHXpVPuFzY4xoXgLn7GGbr5t qicW/hvk80C9FR5o0cel+FJDhEML91OlwWYTx8HyuHfkGeB9u5qbtP5S/5szRwLCzVl4 TjiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eQeugMSbNm4MoGJLzLTQ1K90HqMCkQsDeLBTGL4VkMo=; b=Nk7kjFob8X1f3lg4YtM3tWIW43onMJjF4sfl5sDwU/S+Ij2/UigJxo2i7B6s23PlVk 9u0gZD2doLwmkQw09FCTB2eIql+Oqwtb+muFIRjlHf0MGG+ONvQ9OE+oB7kLIJkJL9wd a+iCOVPwRL1WRz1qAqeIvnInN+p4H1NOeJ3c4MbxeizXYAB0T3Ocp3vftuQ8S7KVYSHd qCEwyfBw0udeJU6sPlD9kN0nN00l4yGSM/Y3MAb/OiElX6pfsSA0vrK3HxZAo0OLTFX9 w0wiFlDuWb3Jsh33J78R2DoPzuUcJPAiQo9pNsTMd0JwwVr7L0uJXYwNVr1XoqnhrqVh 7eSw== X-Gm-Message-State: AOAM531dvJ5aopBNDLIrj4j9afz90bOhIf+OljBY77aNRvLGdjBosglk 1SzKNq3gM/x4DDMY5U4tkQMFog== X-Google-Smtp-Source: ABdhPJwM5F5CftRbSvYRv3kUr5yxBYf5c+QTnBmrJtpThRGN8qtcsxzNDcx41GF7jYUmHq+NVA49eA== X-Received: by 2002:a7b:ca4a:: with SMTP id m10mr22398950wml.11.1600674598674; Mon, 21 Sep 2020 00:49:58 -0700 (PDT) Received: from bender.baylibre.local (home.beaume.starnux.net. [82.236.8.43]) by smtp.gmail.com with ESMTPSA id o16sm17854778wrp.52.2020.09.21.00.49.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2020 00:49:58 -0700 (PDT) From: Neil Armstrong To: lorenzo.pieralisi@arm.com, yue.wang@Amlogic.com, robh@kernel.org Subject: [PATCH] PCI: dwc/meson: do not fail on wait linkup timeout Date: Mon, 21 Sep 2020 09:49:53 +0200 Message-Id: <20200921074953.25289-1-narmstrong@baylibre.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_035001_748596_67C4B935 X-CRM114-Status: GOOD ( 13.03 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, Neil Armstrong , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org When establish link timeouts, probe fails but the error is unrelated since the PCIe controller has been probed succesfully. Align with most of the other dw-pcie drivers and ignore return of dw_pcie_wait_for_link() in the host_init callback. Signed-off-by: Neil Armstrong Tested-by: Kevin Hilman --- drivers/pci/controller/dwc/pci-meson.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c index 33deb290c4e7..846275e68fbc 100644 --- a/drivers/pci/controller/dwc/pci-meson.c +++ b/drivers/pci/controller/dwc/pci-meson.c @@ -383,10 +383,7 @@ static int meson_pcie_host_init(struct pcie_port *pp) pp->bridge->ops = &meson_pci_ops; - ret = meson_pcie_establish_link(mp); - if (ret) - return ret; - + meson_pcie_establish_link(mp); dw_pcie_msi_init(pp); return 0;