From patchwork Tue Sep 22 09:15:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 11791955 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E45B66CB for ; Tue, 22 Sep 2020 09:17:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B37C2075E for ; Tue, 22 Sep 2020 09:17:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dj7+AfLS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cNxw5fQ0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B37C2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=zZeBXEIQyp+RqID8HQsGmcghGPcv8d6bPU8T/hDqMd4=; b=dj7+AfLSIzHfcwmAgeahZFUue/ r48Dhpcl23UcMaGyqlpwu4mPk2e3CX2+XLvzbYMel4XS6kvGhnTlCoz49Lw+Mzpt3BF7AQJnWe4Uv lplMmN3IPuInB85kMvClOm+jUURxQ3Kp1xB3e23kf+6ga+1E9o+dTl4LQ0AVbZ320VBeNRPJTqLyV Z6HZ7vr/kKn/2KFCOX+cRiA+mQf+kmnh2LDmZ0Z7djtYNfflU7c+2bfNAhWGsyxL+75w2aj/O4d7o lTkR++CVLeZSYOTgLExd22gPDHtc6z70J2TvuLLrNscZIYXuIOXwbzQPUv9ijEvAyDeG4Xd3cCKIE VxIxVGwA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKePE-0006vD-AQ; Tue, 22 Sep 2020 09:16:12 +0000 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKeP1-0006tR-Pd for linux-arm-kernel@lists.infradead.org; Tue, 22 Sep 2020 09:16:10 +0000 Received: by mail-lf1-x143.google.com with SMTP id y2so17194207lfy.10 for ; Tue, 22 Sep 2020 02:15:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IWzVGk4JwxAprXdefL8n0YBnT6uhEhTXmeWIi4FWIck=; b=cNxw5fQ0uZBDyY/R+kJ2M+FcXhEbwNU29/OqthyaEOWySCWH6RBjlnywY6bEqih57R 7kQg1/r4YO+V1y4bstBNWWDJ+Xj7qGDXNIg4Gib4hV2Wy8iM7EqEmot8wk6I7Jq9usnQ nXDalPtY4jWWXU6W6w4gklsD+ZNowmQFOaW07wS794eY0tkOWVh5DdUn+7+VHxDcmA7X 1r60oDoeA1+R47/SLVHuP+x6OSOV9SZ6Eu1sTuvzEeK4xLwp4RcR7MWWTI1uvDEoVrhP 3CoOhvt1GBfB4oAbFPviF2HRVvI2gQTL+zRQ4ZDKr84aj6C94VQZBHqg4T7kkQ6f1K0l uLhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IWzVGk4JwxAprXdefL8n0YBnT6uhEhTXmeWIi4FWIck=; b=k/d/vyEofg3jG72+0HCdXMApMwt77qDmGODa7WJjohvnqqqUbt+j644FNt5EgH0zaB Q4tli8Kfh7dMKKTsgrgcxmG6YIDmUQs+aZxcmBwekbfnwd+1NDAZpKf1G8iRSnCfY07N u+5GYreBM4quYh8Qd/G7iahb+T7UDn0ZFvKwdtajs7VeYL0KvljLjDmk4iEjkGJ7V3F+ oDzuHC7ub0D/1xXv3ehkQefNCHA+SfFzlSqJQ8xb5MgZFifuxNcwPswR9GuNJXIUplYf NwWcRiH6g9HYL+b5FnABsMbD7HDKZgl/KrUMGebALnwhKX+vSNoMr/7p/alSJTQAbgUN mZVA== X-Gm-Message-State: AOAM532O9avr5VDgHvnb4vWzR4uORauFjhN8Iy6eyf97e2JxKmmqWrR4 zKA9PgU7I768If31DW9+w70Fiw== X-Google-Smtp-Source: ABdhPJyyAf5H9EGRPv//u95wgcn0lOO+Bs/RWiEEBxCxgowihC4TkgFFBiV+xkjYmXxAbrBxm13aXw== X-Received: by 2002:a05:6512:3048:: with SMTP id b8mr1437725lfb.73.1600766158463; Tue, 22 Sep 2020 02:15:58 -0700 (PDT) Received: from localhost.localdomain (h-155-4-133-169.NA.cust.bahnhof.se. [155.4.133.169]) by smtp.gmail.com with ESMTPSA id 10sm3321516lfo.197.2020.09.22.02.15.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 02:15:57 -0700 (PDT) From: Ulf Hansson To: "Rafael J . Wysocki" , Daniel Lezcano , linux-pm@vger.kernel.org Subject: [PATCH] cpuidle: Drop misleading comments about RCU usage Date: Tue, 22 Sep 2020 11:15:50 +0200 Message-Id: <20200922091550.90191-1-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_051605_036581_08D5822B X-CRM114-Status: GOOD ( 12.61 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:143 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Ulf Hansson , linux-arm-kernel@lists.infradead.org, Lina Iyer Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The commit 1098582a0f6c ("sched,idle,rcu: Push rcu_idle deeper into the idle path"), moved the calls rcu_idle_enter|exit() into the cpuidle core. However, it forgot to remove a couple of comments in enter_s2idle_proper() about why RCU_NONIDLE earlier was needed. So, let's drop them as they have become a bit misleading. Cc: Peter Zijlstra (Intel) Signed-off-by: Ulf Hansson --- drivers/cpuidle/cpuidle.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index 6c7e5621cf9a..29e84687f3c3 100644 --- a/drivers/cpuidle/cpuidle.c +++ b/drivers/cpuidle/cpuidle.c @@ -142,11 +142,6 @@ static void enter_s2idle_proper(struct cpuidle_driver *drv, time_start = ns_to_ktime(local_clock()); - /* - * trace_suspend_resume() called by tick_freeze() for the last CPU - * executing it contains RCU usage regarded as invalid in the idle - * context, so tell RCU about that. - */ tick_freeze(); /* * The state used here cannot be a "coupled" one, because the "coupled" @@ -159,11 +154,6 @@ static void enter_s2idle_proper(struct cpuidle_driver *drv, target_state->enter_s2idle(dev, drv, index); if (WARN_ON_ONCE(!irqs_disabled())) local_irq_disable(); - /* - * timekeeping_resume() that will be called by tick_unfreeze() for the - * first CPU executing it calls functions containing RCU read-side - * critical sections, so tell RCU about that. - */ if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) rcu_idle_exit(); tick_unfreeze();