diff mbox series

[1/2] arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node

Message ID 20200923101225.1513392-2-email2tema@gmail.com
State New
Headers show
Series arm64: dts: rockchip: rk3399-khadas-edge: missed nodes | expand

Commit Message

Artem Lapkin Sept. 23, 2020, 10:12 a.m. UTC
From: Artem Lapkin <art@khadas.com>

The Khadas Edge Boards uses winbond - w25q128 spi flash with 104Mhz
---
 .../boot/dts/rockchip/rk3399-khadas-edge.dtsi      | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Heiko Stübner Sept. 23, 2020, 10:57 a.m. UTC | #1
Hi Artem,

please make the subject something like
"arm64: dts: rockchip: add spiflash node to rk3399-khadas-edge"

Am Mittwoch, 23. September 2020, 12:12:24 CEST schrieb Artem Lapkin:
> From: Artem Lapkin <art@khadas.com>
> 
> The Khadas Edge Boards uses winbond - w25q128 spi flash with 104Mhz

Missing "Signed-off-by: ..."

> ---
>  .../boot/dts/rockchip/rk3399-khadas-edge.dtsi      | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> index e36837c04dc..42ebbd6fa46 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> @@ -805,3 +805,17 @@ &vopl {
>  &vopl_mmu {
>  	status = "okay";
>  };
> +
> +
no double empty lines please

> +&spi1 {

please group the &spi1 alphabetically in the file

> +    max-freq = <104000000>;

not part of any binding, spi-max-frequency below should be enough.

> +    status = "okay";
> +
> +    spiflash: flash@0 {
> +    u-boot,dm-pre-reloc;

u-boot specific, please drop

> +    compatible = "winbond,w25q128fw", "jedec,spi-nor";
> +    reg = <0>;
> +    spi-max-frequency = <104000000>;
> +    };
> +};
> +
> 


Heiko
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
index e36837c04dc..42ebbd6fa46 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
@@ -805,3 +805,17 @@  &vopl {
 &vopl_mmu {
 	status = "okay";
 };
+
+
+&spi1 {
+    max-freq = <104000000>;
+    status = "okay";
+
+    spiflash: flash@0 {
+    u-boot,dm-pre-reloc;
+    compatible = "winbond,w25q128fw", "jedec,spi-nor";
+    reg = <0>;
+    spi-max-frequency = <104000000>;
+    };
+};
+