Message ID | 20201001152148.29747-8-l.stelmach@samsung.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=FGs6=DI=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F16D06CB for <patchwork-linux-arm@patchwork.kernel.org>; Thu, 1 Oct 2020 15:26:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C08A020719 for <patchwork-linux-arm@patchwork.kernel.org>; Thu, 1 Oct 2020 15:26:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0YqBIuCg"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="MMthWRY3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C08A020719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:MIME-Version:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6/IooeSHvQMjpR80VKoHLWiVfGoNegnnaIgLUeRhS1w=; b=0YqBIuCgTKyztpo+0PBZj2fW9 7OnQcx+P0Lz0HRstHL2wuIJzCWvonqNY5ps5UXSAtsa6FPQTUldEL0z5EM93qEvYszp77U+MARLZO kqWqbZp2wXw68g4D8lLLDILVmYn5w8sv6cQa2k779b9vqf8obeEpkp0sW8ja3DwURcLSZgsN25pWL xbe2PCHvt/qcFh5a+dKQDHDF/D5P8GoNy+yDc78pgyl6IB/Giv2v6as10XPA9KGvYiWxeGtoYIIC8 jhyFpoI+/AObg0vVefgdMY/sW2267LWyYevMQ75vDkAwUI8zrtfknFGBdidAwB2HOK2xEPUUYTpxh SZuGpiIgg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO0RM-0000zg-Rt; Thu, 01 Oct 2020 15:24:16 +0000 Received: from mailout2.w1.samsung.com ([210.118.77.12]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO0Py-0000JH-I2 for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 15:22:58 +0000 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20201001152249euoutp02d26c0b17c7ddf76654cd08bdfcc5e949~555UAdVoK2412124121euoutp02B for <linux-arm-kernel@lists.infradead.org>; Thu, 1 Oct 2020 15:22:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20201001152249euoutp02d26c0b17c7ddf76654cd08bdfcc5e949~555UAdVoK2412124121euoutp02B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1601565769; bh=+RhGw1aBvT/TFJWvkjxUmVoP7hLaAZ8E8m5e3M8QeyM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MMthWRY3T+6jsz5IrxrbH31WcxEeUoyGrigEM/q634Kg/tPwVsc7IB5jczw3Kw4zo PG3PFW5rqb9t+gMH0I9b6qFcWhXjTr63Si5a0wV+FRTvx2ASkXdKCyPCWNx1fZmV3/ gPvhMHvons5HEWUovJiS2sxn6im+aVqQOMEu6PDo= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20201001152249eucas1p2a8d25d31e37e9de575a04164d63354ae~555Tk1Pms2407924079eucas1p2I; Thu, 1 Oct 2020 15:22:49 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 59.2F.06456.944F57F5; Thu, 1 Oct 2020 16:22:49 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20201001152248eucas1p132a63f588f62d902879322ebadd67173~555TRY1gd0137901379eucas1p1o; Thu, 1 Oct 2020 15:22:48 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20201001152248eusmtrp1bbb5a920e4e336c568a84ae502568476~555TQtt1-2671626716eusmtrp1j; Thu, 1 Oct 2020 15:22:48 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-4b-5f75f44983c0 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 03.A5.06314.844F57F5; Thu, 1 Oct 2020 16:22:48 +0100 (BST) Received: from localhost (unknown [106.120.51.46]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201001152248eusmtip1c2222e55fb3d01f3e8a527901003c2e4~555TEpvrl2696126961eusmtip1L; Thu, 1 Oct 2020 15:22:48 +0000 (GMT) From: =?utf-8?q?=C5=81ukasz_Stelmach?= <l.stelmach@samsung.com> To: Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Tomasz Figa <tomasz.figa@gmail.com>, Andi Shyti <andi@etezian.org>, Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 RESEND 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value Date: Thu, 1 Oct 2020 17:21:46 +0200 Message-Id: <20201001152148.29747-8-l.stelmach@samsung.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201001152148.29747-1-l.stelmach@samsung.com> MIME-Version: 1.0 Organization: Samsung R&D Institute Poland X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTYRjG+Xa2c47i9DgXvthFHAUpOBMrDqmRZjH/6kYYZdnMg5PclB1n aoFmqGWmqVi2pKQsRcrLvF8QndFK04FBaqk51LwheSUVyzweI/973u/9vc/7vPCRmKRG5ERG aGIYrUYZKcOthbXvV8zugYu6kAOPDAT9cnlcQFfml4voPMsoTmeNTGO02VxB0P3GEkQbRr6I 6M+NBTidb24R0Lfn+gn67btBgi5tXEPHbBS9RfOYokE/SCgMpfdwRVVRoiKzuhQpFgx7TuMX rX3CmMiIWEbrcfSqtcpkfo2i1/G4pcY0LAlNidIRQQJ1EFZ2pCMrUkKVIBjqck9H1ht6EUHm r2IRXywgmLVMCziK47M7LEK+UYygKm+V4ItxBM3LA4ijcMoPsl592ByXUnUCyF4wC7kGRukg o8GIpyOSdKCCYeJrHCeF1D6YWAngCDHlDWtLzwl+mTOkFdfhnLaifKA7ux3nGXv4+GR009GO coM3yb1b7s5wp+Ypxs8OEdDUFM7rACj7PoN47QBTpuot/13QmZsh5CIAlQi5OYe5xEBlIKgt WBbyjDcMdK9uJsYoVyhv9OBxP5g1+/LSFvpm7PkAtpBT+xjjn8VwN1XCe+yFsqzmLT8neDBV gh4imX7bKfpt8fX/VxUirBQ5MjpWHc6wnhrmhpxVqlmdJlx+LUptQBufqfOPab4eLfWEGhFF IpmNWGXUhUhEylg2Xm1EQGIyqdi/q/OKRBymjE9gtFEhWl0kwxrRTlIocxR7vZi8LKHClTHM dYaJZrT/ugLSyikJadpCbLx6mLDfXir5D4XUBSusN4amoAR3//vrFrvowSA3+Ug3Cp4Y6xo9 YXPmXIdD6thx/eScy5Fo07ihMnB//6eZ5OHqPt+zPysO+Reww+1BzxLOn6o0JY8SytVbQ99a UopbXOnW1uALc2fN0oXdResNze156ptyy8mZS1FtRTIhq1J6umFaVvkX8CCHJEgDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNIsWRmVeSWpSXmKPExsVy+t/xu7oeX0rjDf5161ss/vGcyWLjjPWs FlMfPmGz6H/8mtni/PkN7BY3D61gtNj0+BqrxeVdc9gsZpzfx2TR+PEmu8XaI3fZLVbt+sPo wONxfcknZo+ds+6ye2xa1cnmsXlJvUffllWMHp83yQWwRenZFOWXlqQqZOQXl9gqRRtaGOkZ WlroGZlY6hkam8daGZkq6dvZpKTmZJalFunbJehlHD+/jLHgP1vF113tzA2Mr1i7GDk5JARM JCaeesjSxcjFISSwlFFi96r7QA4HUEJKYuXcdIgaYYk/17rYIGqeMkrc7pzGDJJgE3CU6F96 ghUkISKwn0ni0gWQZk4OZoFyiUuznrOD2MICURKPV+xgBxnKIqAq8eKnC0iYV8Ba4s/X+ewQ C+Ql2pdvZwOxOQVsJM5NPAxmCwnkSuzefZQNol5Q4uTMJ2C3MQuoS6yfJwQS5hfQkljTdB1q q7xE89bZzBMYhWYh6ZiF0DELSdUCRuZVjCKppcW56bnFhnrFibnFpXnpesn5uZsYgRG57djP zTsYL20MPsQowMGoxMMrcKA0Xog1say4MvcQowQHs5IIr9PZ03FCvCmJlVWpRfnxRaU5qcWH GE2BvpzILCWanA9MFnkl8YamhuYWlobmxubGZhZK4rwdAgdjhATSE0tSs1NTC1KLYPqYODil GhgTtsZsE2/60f6nz/z6+mmBz2qvVWn/vvY1Szt3aYPI4vwgp5IlHM8TNi1dMe3oi6hc2zN7 JV+3Tv0vmBQ479LD+v/Fzm7hVUvWrmI9PG8xf7J3+zFZeUuNeTnLWVeovTrU6KARVsYpPP3H xj82v8/Me+r7K2H147lanNt2V2+c9z99RUwBN5evEktxRqKhFnNRcSIAweqE8t4CAAA= X-CMS-MailID: 20201001152248eucas1p132a63f588f62d902879322ebadd67173 X-Msg-Generator: CA X-RootMTR: 20201001152248eucas1p132a63f588f62d902879322ebadd67173 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20201001152248eucas1p132a63f588f62d902879322ebadd67173 References: <20200821161401.11307-1-l.stelmach@samsung.com> <20201001152148.29747-1-l.stelmach@samsung.com> <CGME20201001152248eucas1p132a63f588f62d902879322ebadd67173@eucas1p1.samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_112250_792622_892EFE69 X-CRM114-Status: GOOD ( 16.87 ) X-Spam-Score: -5.2 (-----) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-5.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [210.118.77.12 listed in wl.mailspike.net] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [210.118.77.12 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: b.zolnierkie@samsung.com, =?utf-8?q?=C5=81ukasz_Stelmach?= <l.stelmach@samsung.com>, m.szyprowski@samsung.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org |
Series |
[v2,RESEND,1/9] spi: spi-s3c64xx: swap s3c64xx_spi_set_cs() and s3c64xx_enable_datapath()
|
expand
|
On Thu, Oct 01, 2020 at 05:21:46PM +0200, Łukasz Stelmach wrote: > Make sure the cur_speed value used in s3c64xx_enable_datapath() > to configure DMA channel and in s3c64xx_wait_for_*() to calculate the > transfer timeout is set to the actual value of (half) the clock speed. > > Suggested-by: Tomasz Figa <tomasz.figa@gmail.com> > Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com> > --- > drivers/spi/spi-s3c64xx.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 02de734b8ab1..89c162efe355 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -626,6 +626,7 @@ static int s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd) ret = clk_set_rate(sdd->src_clk, sdd->cur_speed * 2); if (ret) return ret; + sdd->cur_speed = clk_get_rate(sdd->src_clk) / 2; } else { /* Configure Clock */ val = readl(regs + S3C64XX_SPI_CLK_CFG);
Make sure the cur_speed value used in s3c64xx_enable_datapath() to configure DMA channel and in s3c64xx_wait_for_*() to calculate the transfer timeout is set to the actual value of (half) the clock speed. Suggested-by: Tomasz Figa <tomasz.figa@gmail.com> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com> --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+)