Message ID | 20201024162515.30032-10-wens@kernel.org (mailing list archive) |
---|---|
State | Mainlined, archived |
Headers | show |
Series | [01/10] Revert "arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high" | expand |
On Sun, Oct 25, 2020 at 12:25:15AM +0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai <wens@csie.org> > > The Ethernet PHY on the Bananapi M64 has the RX and TX delays > enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins. > > Fix the phy-mode description to correct reflect this so that the > implementation doesn't reconfigure the delays incorrectly. This > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > rx/tx delay config"). > > Fixes: e7295499903d ("arm64: allwinner: bananapi-m64: Enable dwmac-sun8i") > Fixes: 94f442886711 ("arm64: dts: allwinner: A64: Restore EMAC changes") > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > index 3ea5182ca489..e5e840b9fbb4 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > @@ -105,7 +105,7 @@ &ehci1 { > &emac { > pinctrl-names = "default"; > pinctrl-0 = <&rgmii_pins>; > - phy-mode = "rgmii"; > + phy-mode = "rgmii-id"; > phy-handle = <&ext_rgmii_phy>; > phy-supply = <®_dc1sw>; > status = "okay"; > -- > 2.28.0 Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com> Thanks
Dne sobota, 24. oktober 2020 ob 21:58:03 CET je Corentin Labbe napisal(a): > On Sun, Oct 25, 2020 at 12:25:15AM +0800, Chen-Yu Tsai wrote: > > From: Chen-Yu Tsai <wens@csie.org> > > > > The Ethernet PHY on the Bananapi M64 has the RX and TX delays > > enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins. > > > > Fix the phy-mode description to correct reflect this so that the > > implementation doesn't reconfigure the delays incorrectly. This > > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > > rx/tx delay config"). > > > > Fixes: e7295499903d ("arm64: allwinner: bananapi-m64: Enable dwmac-sun8i") > > Fixes: 94f442886711 ("arm64: dts: allwinner: A64: Restore EMAC changes") > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > --- > > arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/ arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > > index 3ea5182ca489..e5e840b9fbb4 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > > @@ -105,7 +105,7 @@ &ehci1 { > > &emac { > > pinctrl-names = "default"; > > pinctrl-0 = <&rgmii_pins>; > > - phy-mode = "rgmii"; > > + phy-mode = "rgmii-id"; > > phy-handle = <&ext_rgmii_phy>; > > phy-supply = <®_dc1sw>; > > status = "okay"; > > -- > > 2.28.0 > > Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com> Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
On Sun, Oct 25, 2020 at 12:25:15AM +0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai <wens@csie.org> > > The Ethernet PHY on the Bananapi M64 has the RX and TX delays > enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins. > > Fix the phy-mode description to correct reflect this so that the > implementation doesn't reconfigure the delays incorrectly. This > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > rx/tx delay config"). > > Fixes: e7295499903d ("arm64: allwinner: bananapi-m64: Enable dwmac-sun8i") > Fixes: 94f442886711 ("arm64: dts: allwinner: A64: Restore EMAC changes") > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Applied all the patches, thanks! Maxime
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts index 3ea5182ca489..e5e840b9fbb4 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts @@ -105,7 +105,7 @@ &ehci1 { &emac { pinctrl-names = "default"; pinctrl-0 = <&rgmii_pins>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-handle = <&ext_rgmii_phy>; phy-supply = <®_dc1sw>; status = "okay";