diff mbox series

[1/6] kselftest/arm64: Fix check_buffer_fill test

Message ID 20201026121248.2340-2-vincenzo.frascino@arm.com (mailing list archive)
State New, archived
Headers show
Series kselftest/arm64: MTE fixes | expand

Commit Message

Vincenzo Frascino Oct. 26, 2020, 12:12 p.m. UTC
The check_buffer_fill test reports the error below because the test
plan is not declared correctly:

  # Planned tests != run tests (0 != 20)

Fix the test adding the correct test plan declaration.

Fixes: e9b60476bea0 ("kselftest/arm64: Add utilities and a test to validate mte memory")
Cc: Shuah Khan <shuah@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Gabor Kertesz <gabor.kertesz@arm.com>
Cc: Amit Daniel Kachhap <amit.kachhap@arm.com>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
---
 tools/testing/selftests/arm64/mte/check_buffer_fill.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Amit Daniel Kachhap Oct. 27, 2020, 10:25 a.m. UTC | #1
On 10/26/20 5:42 PM, Vincenzo Frascino wrote:
> The check_buffer_fill test reports the error below because the test
> plan is not declared correctly:
> 
>    # Planned tests != run tests (0 != 20)
> 
> Fix the test adding the correct test plan declaration.

This change is required and got missed earlier.
Acked by: Amit Daniel Kachhap <amit.kachhap@arm.com>

> 
> Fixes: e9b60476bea0 ("kselftest/arm64: Add utilities and a test to validate mte memory")
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Gabor Kertesz <gabor.kertesz@arm.com>
> Cc: Amit Daniel Kachhap <amit.kachhap@arm.com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
>   tools/testing/selftests/arm64/mte/check_buffer_fill.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/selftests/arm64/mte/check_buffer_fill.c b/tools/testing/selftests/arm64/mte/check_buffer_fill.c
> index 242635d79035..c9fa141ebdcc 100644
> --- a/tools/testing/selftests/arm64/mte/check_buffer_fill.c
> +++ b/tools/testing/selftests/arm64/mte/check_buffer_fill.c
> @@ -417,6 +417,9 @@ int main(int argc, char *argv[])
>   	/* Register SIGSEGV handler */
>   	mte_register_signal(SIGSEGV, mte_default_handler);
>   
> +	/* Set test plan */
> +	ksft_set_plan(20);
> +
>   	/* Buffer by byte tests */
>   	evaluate_test(check_buffer_by_byte(USE_MMAP, MTE_SYNC_ERR),
>   	"Check buffer correctness by byte with sync err mode and mmap memory\n");
>
diff mbox series

Patch

diff --git a/tools/testing/selftests/arm64/mte/check_buffer_fill.c b/tools/testing/selftests/arm64/mte/check_buffer_fill.c
index 242635d79035..c9fa141ebdcc 100644
--- a/tools/testing/selftests/arm64/mte/check_buffer_fill.c
+++ b/tools/testing/selftests/arm64/mte/check_buffer_fill.c
@@ -417,6 +417,9 @@  int main(int argc, char *argv[])
 	/* Register SIGSEGV handler */
 	mte_register_signal(SIGSEGV, mte_default_handler);
 
+	/* Set test plan */
+	ksft_set_plan(20);
+
 	/* Buffer by byte tests */
 	evaluate_test(check_buffer_by_byte(USE_MMAP, MTE_SYNC_ERR),
 	"Check buffer correctness by byte with sync err mode and mmap memory\n");