| Message ID | 20201027104132.105485-3-tomi.valkeinen@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: ti: AM6 and J721e display dts changes | expand |
On 12:41-20201027, Tomi Valkeinen wrote: [...] > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > index 52e121155563..5a36d65755ee 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > @@ -83,6 +83,31 @@ sound0: sound@0 { > "cpb-codec-scki", > "cpb-codec-scki-48000", "cpb-codec-scki-44100"; > }; > + > + dp_pwr_3v3: fixedregulator-dp-prw { > + compatible = "regulator-fixed"; > + regulator-name = "dp-pwr"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&exp4 0 0>; /* P0 - DP0_PWR_SW_EN */ > + enable-active-high; > + > + /* Always on for now, until dp-connector driver can handle this */ > + regulator-always-on; > + }; > + > + dp0: connector { > + compatible = "dp-connector"; This is not documented? I see the following on checkpatch: +WARNING: DT compatible string "dp-connector" appears un-documented -- check ./Documentation/devicetree/bindings/ +#42: FILE: arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:100: ++ compatible = "dp-connector"; + mechanically convert to the typical style using --fix or --fix-inplace. + them to the maintainer, see CHECKPATCH in MAINTAINERS. > + label = "DP0"; > + type = "full-size"; > + dp-pwr-supply = <&dp_pwr_3v3>; > + > + port { > + dp_connector_in: endpoint { > + remote-endpoint = <&dp0_out>; > + }; > + }; > + }; > }; > > &main_pmx0 { > @@ -119,6 +144,12 @@ J721E_IOPAD(0x214, PIN_OUTPUT, 4) /* (V4) MCAN1_TX.USB1_DRVVBUS */ > >; > }; > > + dp0_pins_default: dp0_pins_default { please don't use _ in node names dp0-pins-default perhaps? [...]
On 27/10/2020 14:20, Nishanth Menon wrote: > On 12:41-20201027, Tomi Valkeinen wrote: > [...] > >> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts >> index 52e121155563..5a36d65755ee 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts >> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts >> @@ -83,6 +83,31 @@ sound0: sound@0 { >> "cpb-codec-scki", >> "cpb-codec-scki-48000", "cpb-codec-scki-44100"; >> }; >> + >> + dp_pwr_3v3: fixedregulator-dp-prw { >> + compatible = "regulator-fixed"; >> + regulator-name = "dp-pwr"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + gpio = <&exp4 0 0>; /* P0 - DP0_PWR_SW_EN */ >> + enable-active-high; >> + >> + /* Always on for now, until dp-connector driver can handle this */ >> + regulator-always-on; >> + }; >> + >> + dp0: connector { >> + compatible = "dp-connector"; > > This is not documented? I see the following on checkpatch: > +WARNING: DT compatible string "dp-connector" appears un-documented -- check ./Documentation/devicetree/bindings/ > +#42: FILE: arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:100: > ++ compatible = "dp-connector"; > + mechanically convert to the typical style using --fix or --fix-inplace. > + them to the maintainer, see CHECKPATCH in MAINTAINERS. Yes, I mentioned this in the cover letter. > >> + label = "DP0"; >> + type = "full-size"; >> + dp-pwr-supply = <&dp_pwr_3v3>; >> + >> + port { >> + dp_connector_in: endpoint { >> + remote-endpoint = <&dp0_out>; >> + }; >> + }; >> + }; >> }; >> >> &main_pmx0 { >> @@ -119,6 +144,12 @@ J721E_IOPAD(0x214, PIN_OUTPUT, 4) /* (V4) MCAN1_TX.USB1_DRVVBUS */ >> >; >> }; >> >> + dp0_pins_default: dp0_pins_default { > > please don't use _ in node names dp0-pins-default perhaps? Ok. Tomi
On 16:44-20201027, Tomi Valkeinen wrote: > On 27/10/2020 14:20, Nishanth Menon wrote: > > On 12:41-20201027, Tomi Valkeinen wrote: > > [...] > > > >> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > >> index 52e121155563..5a36d65755ee 100644 > >> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > >> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > >> @@ -83,6 +83,31 @@ sound0: sound@0 { > >> "cpb-codec-scki", > >> "cpb-codec-scki-48000", "cpb-codec-scki-44100"; > >> }; > >> + > >> + dp_pwr_3v3: fixedregulator-dp-prw { > >> + compatible = "regulator-fixed"; > >> + regulator-name = "dp-pwr"; > >> + regulator-min-microvolt = <3300000>; > >> + regulator-max-microvolt = <3300000>; > >> + gpio = <&exp4 0 0>; /* P0 - DP0_PWR_SW_EN */ > >> + enable-active-high; > >> + > >> + /* Always on for now, until dp-connector driver can handle this */ > >> + regulator-always-on; > >> + }; > >> + > >> + dp0: connector { > >> + compatible = "dp-connector"; > > > > This is not documented? I see the following on checkpatch: > > +WARNING: DT compatible string "dp-connector" appears un-documented -- check ./Documentation/devicetree/bindings/ > > +#42: FILE: arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:100: > > ++ compatible = "dp-connector"; > > + mechanically convert to the typical style using --fix or --fix-inplace. > > + them to the maintainer, see CHECKPATCH in MAINTAINERS. > > Yes, I mentioned this in the cover letter. > Aaah thanks. We may need to look at reposting this patch after it hits mainline.
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts index 52e121155563..5a36d65755ee 100644 --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts @@ -83,6 +83,31 @@ sound0: sound@0 { "cpb-codec-scki", "cpb-codec-scki-48000", "cpb-codec-scki-44100"; }; + + dp_pwr_3v3: fixedregulator-dp-prw { + compatible = "regulator-fixed"; + regulator-name = "dp-pwr"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&exp4 0 0>; /* P0 - DP0_PWR_SW_EN */ + enable-active-high; + + /* Always on for now, until dp-connector driver can handle this */ + regulator-always-on; + }; + + dp0: connector { + compatible = "dp-connector"; + label = "DP0"; + type = "full-size"; + dp-pwr-supply = <&dp_pwr_3v3>; + + port { + dp_connector_in: endpoint { + remote-endpoint = <&dp0_out>; + }; + }; + }; }; &main_pmx0 { @@ -119,6 +144,12 @@ J721E_IOPAD(0x214, PIN_OUTPUT, 4) /* (V4) MCAN1_TX.USB1_DRVVBUS */ >; }; + dp0_pins_default: dp0_pins_default { + pinctrl-single,pins = < + J721E_IOPAD(0x1c4, PIN_INPUT, 5) /* SPI0_CS1.DP0_HPD */ + >; + }; + main_i2c1_exp4_pins_default: main-i2c1-exp4-pins-default { pinctrl-single,pins = < J721E_IOPAD(0x230, PIN_INPUT, 7) /* (U2) ECAP0_IN_APWM_OUT.GPIO1_11 */ @@ -538,6 +569,47 @@ &dss { <&k3_clks 152 6>, /* PLL19_HSDIV0 */ <&k3_clks 152 11>, /* PLL18_HSDIV0 */ <&k3_clks 152 18>; /* PLL23_HSDIV0 */ + + status = "ok"; +}; + +&dss_ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + dpi0_out: endpoint { + remote-endpoint = <&dp0_in>; + }; + }; +}; + +&mhdp { + status = "ok"; + + pinctrl-names = "default"; + pinctrl-0 = <&dp0_pins_default>; +}; + +&dp0_ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + dp0_in: endpoint { + remote-endpoint = <&dpi0_out>; + }; + }; + + port@4 { + reg = <4>; + dp0_out: endpoint { + remote-endpoint = <&dp_connector_in>; + }; + }; }; &mcasp10 {
Add DisplayPort support. The DP PWR is currently set as 'regulator-always-on', as we don't have a dp-connector driver that would handle the power. When we do get such a driver, the 'regulator-always-on' can be dropped. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> --- .../dts/ti/k3-j721e-common-proc-board.dts | 72 +++++++++++++++++++ 1 file changed, 72 insertions(+)