From patchwork Fri Oct 30 05:54:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Billy Tsai X-Patchwork-Id: 11868665 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4ED4C00A89 for ; Fri, 30 Oct 2020 08:00:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D9E420719 for ; Fri, 30 Oct 2020 08:00:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uO7q3oh8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Hc41FA8Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D9E420719 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C3QUEN7vq9Wz/qlCAS0PUWBVeSFPcQ5eiUSbwMuQtVU=; b=uO7q3oh8dLunhhJS45FS45Su5 0C23eTzEXe6FMDy2f8B6OfCztsoQhIjiRLWRdfU/Wvv675PJ2EHZIEULgq/9dipl/E5siQVrc0qlF 9t0AezX7aTqDHT5HRub7fWdLFDNRxplb5O7y3mYF3QkHkXGhuX1EAk5KT35GasyUZTKdbB9cz9j8t Dkp8dISeBH8nFpcNG4S47WGApHHq5z3g6YWKhZBe0ynT9NfkcM/QmugCGNnoHVxfFF/oCoIxRhS7X YIiUSW+1E4WCeBkd2nZt0HnqQl7nN4e2YIQbL7AMSTgTDDapcKNMR8j8pKYP8XIfh+HfYNmPwZviM XTadRrirw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYPJM-0007ce-3S; Fri, 30 Oct 2020 07:59:00 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYPJH-0007Zl-1S for linux-arm-kernel@merlin.infradead.org; Fri, 30 Oct 2020 07:58:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:CC:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0zlza76QQ66z1H/hGhHrxw8ExzWDqcpJz6bxdpbpBuw=; b=Hc41FA8QVUp3zMHhgSF+mIpInW /3td3Z8/zr4XU7mjfuTp7ZOcunDv+JJa1jBeLLbe54JKEo+Ki1POKqyfrZO5Alm9IRCW1NyaGMTFA PiZfhWJLG7E1s9Lh4O2NZRg9uFBE2UHK3trQQTUqtQv2c7BOpGrwvEpDEXGDbxxqHHb2ofH/YoVSP mcbLKFXdcFOGXfsk3AyKdzXLSSdunJ0udnKCSakhPzOBO+ATTaKxi/Idfsx5cH4Xn8p9erJd71sil fVrNatIvju5N5W+QAgGkwGerw3uJG6lNqic+HAttMut24WFURIxOtjbHZjh7ifKwA57AQkYkcCp+b 068JOoEw==; Received: from twspam01.aspeedtech.com ([211.20.114.71]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYNNd-0000Um-E7 for linux-arm-kernel@lists.infradead.org; Fri, 30 Oct 2020 05:55:20 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 09U5pfvL022493; Fri, 30 Oct 2020 13:51:41 +0800 (GMT-8) (envelope-from billy_tsai@aspeedtech.com) Received: from localhost.localdomain (192.168.10.9) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 30 Oct 2020 13:54:56 +0800 From: Billy Tsai To: , , , , , , Subject: [PATCH v2] pinctrl: aspeed: Fix GPI only function problem. Date: Fri, 30 Oct 2020 13:54:50 +0800 Message-ID: <20201030055450.29613-1-billy_tsai@aspeedtech.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201027084417.10137-1-billy_tsai@aspeedtech.com> References: <20201027084417.10137-1-billy_tsai@aspeedtech.com> MIME-Version: 1.0 X-Originating-IP: [192.168.10.9] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 09U5pfvL022493 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201030_055518_151796_FFD025FE X-CRM114-Status: GOOD ( 11.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: BMC-SW@aspeedtech.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Some gpio pin at aspeed soc is input only and the prefix name of these pin is "GPI" only. This patch fine-tune the condition of GPIO check from "GPIO" to "GPI" and it will fix the usage error of banks D and E in the AST2400/AST2500 and banks T and U in the AST2600. Fixes: 4d3d0e4272d8 ("pinctrl: Add core support for Aspeed SoCs") Signed-off-by: Billy Tsai --- drivers/pinctrl/aspeed/pinctrl-aspeed.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c b/drivers/pinctrl/aspeed/pinctrl-aspeed.c index e03ee78b2434..95c8d400ad59 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c @@ -286,13 +286,14 @@ int aspeed_pinmux_set_mux(struct pinctrl_dev *pctldev, unsigned int function, static bool aspeed_expr_is_gpio(const struct aspeed_sig_expr *expr) { /* - * The signal type is GPIO if the signal name has "GPIO" as a prefix. + * The signal type is GPIO if the signal name has "GPI" as a prefix. * strncmp (rather than strcmp) is used to implement the prefix * requirement. * - * expr->signal might look like "GPIOT3" in the GPIO case. + * expr->signal might look like "GPIOB1" in the GPIO case. + * expr->signal might look like "GPIT0" in the GPI case. */ - return strncmp(expr->signal, "GPIO", 4) == 0; + return strncmp(expr->signal, "GPI", 3) == 0; } static bool aspeed_gpio_in_exprs(const struct aspeed_sig_expr **exprs)