| Message ID | 20201103152838.1290217-2-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Rid W=1 warnings in SoC | expand |
On Tue, 3 Nov 2020 15:28:14 +0000, Lee Jones <lee.jones@linaro.org> wrote: > brcmstb_pm_s3_finish() cannot be made static because it is referenced > from brcmstb_pm_s3(), so let's provide a prototype for it instead. > > Fixes the following W=1 kernel build warning(s): > > drivers/soc/bcm/brcmstb/pm/pm-arm.c:395:14: warning: no previous prototype for ‘brcmstb_pm_s3_finish’ [-Wmissing-prototypes] > > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: bcm-kernel-feedback-list@broadcom.com > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- Applied to drivers/next, thanks! -- Florian
On Tue, 03 Nov 2020, Florian Fainelli wrote: > On Tue, 3 Nov 2020 15:28:14 +0000, Lee Jones <lee.jones@linaro.org> wrote: > > brcmstb_pm_s3_finish() cannot be made static because it is referenced > > from brcmstb_pm_s3(), so let's provide a prototype for it instead. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/soc/bcm/brcmstb/pm/pm-arm.c:395:14: warning: no previous prototype for ‘brcmstb_pm_s3_finish’ [-Wmissing-prototypes] > > > > Cc: Florian Fainelli <f.fainelli@gmail.com> > > Cc: bcm-kernel-feedback-list@broadcom.com > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > Applied to drivers/next, thanks! Does your branch not get sucked into -next? Only it's not currently there.
On 11/26/2020 1:20 AM, Lee Jones wrote: > On Tue, 03 Nov 2020, Florian Fainelli wrote: > >> On Tue, 3 Nov 2020 15:28:14 +0000, Lee Jones <lee.jones@linaro.org> wrote: >>> brcmstb_pm_s3_finish() cannot be made static because it is referenced >>> from brcmstb_pm_s3(), so let's provide a prototype for it instead. >>> >>> Fixes the following W=1 kernel build warning(s): >>> >>> drivers/soc/bcm/brcmstb/pm/pm-arm.c:395:14: warning: no previous prototype for ‘brcmstb_pm_s3_finish’ [-Wmissing-prototypes] >>> >>> Cc: Florian Fainelli <f.fainelli@gmail.com> >>> Cc: bcm-kernel-feedback-list@broadcom.com >>> Signed-off-by: Lee Jones <lee.jones@linaro.org> >>> --- >> >> Applied to drivers/next, thanks! > > Does your branch not get sucked into -next? It does not, but rest assured this will make it into 5.11 and you will be copied on the pull request. I will work with Stephen to get the stblinux git tree added to -next.
On Fri, 27 Nov 2020, Florian Fainelli wrote: > > > On 11/26/2020 1:20 AM, Lee Jones wrote: > > On Tue, 03 Nov 2020, Florian Fainelli wrote: > > > >> On Tue, 3 Nov 2020 15:28:14 +0000, Lee Jones <lee.jones@linaro.org> wrote: > >>> brcmstb_pm_s3_finish() cannot be made static because it is referenced > >>> from brcmstb_pm_s3(), so let's provide a prototype for it instead. > >>> > >>> Fixes the following W=1 kernel build warning(s): > >>> > >>> drivers/soc/bcm/brcmstb/pm/pm-arm.c:395:14: warning: no previous prototype for ‘brcmstb_pm_s3_finish’ [-Wmissing-prototypes] > >>> > >>> Cc: Florian Fainelli <f.fainelli@gmail.com> > >>> Cc: bcm-kernel-feedback-list@broadcom.com > >>> Signed-off-by: Lee Jones <lee.jones@linaro.org> > >>> --- > >> > >> Applied to drivers/next, thanks! > > > > Does your branch not get sucked into -next? > > It does not, but rest assured this will make it into 5.11 and you will > be copied on the pull request. I will work with Stephen to get the > stblinux git tree added to -next. Okay, good to know. Thanks Florian.
diff --git a/drivers/soc/bcm/brcmstb/pm/pm-arm.c b/drivers/soc/bcm/brcmstb/pm/pm-arm.c index b1062334e6089..a673fdffe2163 100644 --- a/drivers/soc/bcm/brcmstb/pm/pm-arm.c +++ b/drivers/soc/bcm/brcmstb/pm/pm-arm.c @@ -111,6 +111,8 @@ enum bsp_initiate_command { static struct brcmstb_pm_control ctrl; +noinline int brcmstb_pm_s3_finish(void); + static int (*brcmstb_pm_do_s2_sram)(void __iomem *aon_ctrl_base, void __iomem *ddr_phy_pll_status);
brcmstb_pm_s3_finish() cannot be made static because it is referenced from brcmstb_pm_s3(), so let's provide a prototype for it instead. Fixes the following W=1 kernel build warning(s): drivers/soc/bcm/brcmstb/pm/pm-arm.c:395:14: warning: no previous prototype for ‘brcmstb_pm_s3_finish’ [-Wmissing-prototypes] Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: bcm-kernel-feedback-list@broadcom.com Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/soc/bcm/brcmstb/pm/pm-arm.c | 2 ++ 1 file changed, 2 insertions(+)