| Message ID | 20201105090615.620315-1-martin@geanix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | spi: bcm2835: remove use of uninitialized gpio flags variable | expand |
On Thu, Nov 05, 2020 at 10:06:15AM +0100, Martin Hundebøll wrote: > Removing the duplicate gpio chip select level handling in > bcm2835_spi_setup() left the lflags variable uninitialized. Avoid trhe > use of such variable by passing default flags to > gpiochip_request_own_desc(). Please don't send patches in reply to old threads, it buries them and can make it unclear what is a new patch which needs review. Send new patches as new threads.
On Thu, 5 Nov 2020 10:06:15 +0100, Martin Hundebøll wrote: > Removing the duplicate gpio chip select level handling in > bcm2835_spi_setup() left the lflags variable uninitialized. Avoid trhe > use of such variable by passing default flags to > gpiochip_request_own_desc(). Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: bcm2835: remove use of uninitialized gpio flags variable commit: bc7f2cd7559c5595dc38b909ae9a8d43e0215994 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c index 9b6ba94fe878..7104cf17b848 100644 --- a/drivers/spi/spi-bcm2835.c +++ b/drivers/spi/spi-bcm2835.c @@ -1193,7 +1193,6 @@ static int bcm2835_spi_setup(struct spi_device *spi) struct spi_controller *ctlr = spi->controller; struct bcm2835_spi *bs = spi_controller_get_devdata(ctlr); struct gpio_chip *chip; - enum gpio_lookup_flags lflags; u32 cs; /* @@ -1261,7 +1260,7 @@ static int bcm2835_spi_setup(struct spi_device *spi) spi->cs_gpiod = gpiochip_request_own_desc(chip, 8 - spi->chip_select, DRV_NAME, - lflags, + GPIO_LOOKUP_FLAGS_DEFAULT, GPIOD_OUT_LOW); if (IS_ERR(spi->cs_gpiod)) return PTR_ERR(spi->cs_gpiod);
Removing the duplicate gpio chip select level handling in bcm2835_spi_setup() left the lflags variable uninitialized. Avoid trhe use of such variable by passing default flags to gpiochip_request_own_desc(). Fixes: 5e31ba0c0543 ("spi: bcm2835: fix gpio cs level inversion") Signed-off-by: Martin Hundebøll <martin@geanix.com> --- Feel free to squash this commit with my previous patch, if rebasing for-next is allowed. drivers/spi/spi-bcm2835.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)