| Message ID | 20201108022321.2114430-1-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target | expand |
On Sun, 8 Nov 2020 at 03:23, Nathan Chancellor <natechancellor@gmail.com> wrote: Hi, Thanks for the fixes. Please mark patches with versions, this should be v2. Otherwise maintainer might apply the older one, You also need to add versioning changelog after ---. > $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- \ > INSTALL_DTBS_PATH=rootfs distclean defconfig dtbs dtbs_install All this is still irrelevant. Just: "make dtbs". Don't add unrelated details like how many processes you spawn, where do you want to install DTBS or even all other make targets. Everyone should know how to cross compile so simple: make dtbs > ... > make[3]: *** No rule to make target > 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by > '__dtbs_install' This should be joined with previous line. I mentioned it in your previous patch. > ... Also not needed dots. This is small change and should go with small and accurate description. Blowing the description does not help. Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
Hi Krzysztof, On Sun, Nov 08, 2020 at 10:31:10AM +0100, Krzysztof Kozlowski wrote: > On Sun, 8 Nov 2020 at 03:23, Nathan Chancellor <natechancellor@gmail.com> wrote: > > Hi, > > Thanks for the fixes. > > Please mark patches with versions, this should be v2. Otherwise > maintainer might apply the older one, > You also need to add versioning changelog after ---. I have only sent this one patch. It looks like Anders Roxell sent an identical patch though: https://lore.kernel.org/linux-devicetree/20201105111823.1613337-1-anders.roxell@linaro.org/ > > $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- \ > > INSTALL_DTBS_PATH=rootfs distclean defconfig dtbs dtbs_install > > All this is still irrelevant. Just: "make dtbs". Don't add unrelated > details like how many processes you spawn, where do you want to > install DTBS or even all other make targets. > Everyone should know how to cross compile so simple: make dtbs Sure, I will update it, my apologies. > > ... > > make[3]: *** No rule to make target > > 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by > > '__dtbs_install' > > This should be joined with previous line. I mentioned it in your previous patch. Sure, I usually just let my editor do the auto wrapping but I will put it all onto one line! > > ... > > Also not needed dots. This is small change and should go with small > and accurate description. Blowing the description does not help. > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > > Best regards, > Krzysztof Thank you for the review, I will sent v2 along shortly. Cheers, Nathan
On Sun, 8 Nov 2020 at 20:13, Nathan Chancellor <natechancellor@gmail.com> wrote: > > Hi Krzysztof, > > On Sun, Nov 08, 2020 at 10:31:10AM +0100, Krzysztof Kozlowski wrote: > > On Sun, 8 Nov 2020 at 03:23, Nathan Chancellor <natechancellor@gmail.com> wrote: > > > > Hi, > > > > Thanks for the fixes. > > > > Please mark patches with versions, this should be v2. Otherwise > > maintainer might apply the older one, > > You also need to add versioning changelog after ---. > > I have only sent this one patch. It looks like Anders Roxell sent an > identical patch though: > > https://lore.kernel.org/linux-devicetree/20201105111823.1613337-1-anders.roxell@linaro.org/ Oh, damn, I didn't check the authors and got kind of confused seeing a v1. Nice timing. :) Anyway, thanks for the patch! Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile index 876bf484bbe6..6f0777ee6cd6 100644 --- a/arch/arm64/boot/dts/freescale/Makefile +++ b/arch/arm64/boot/dts/freescale/Makefile @@ -32,7 +32,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb -dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dts +dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
$ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- \ INSTALL_DTBS_PATH=rootfs distclean defconfig dtbs dtbs_install ... make[3]: *** No rule to make target 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by '__dtbs_install' ... It should be .dtb, not .dts. Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards") Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- arch/arm64/boot/dts/freescale/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 39fabe22e0f8c00334882ceac1dc70ffbd7f4871