From patchwork Mon Nov 9 17:39:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Auhagen X-Patchwork-Id: 11892081 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CCDEC2D0A3 for ; Mon, 9 Nov 2020 17:42:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AFC42068D for ; Mon, 9 Nov 2020 17:42:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ISFayI5I"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=voleatech.de header.i=@voleatech.de header.b="G/WgwGGF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AFC42068D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=voleatech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XTujbbhNEr7qCn9hF69nyO0iJI7Q5UYg87RL5qlUIb4=; b=ISFayI5Ie7Z4qCooSwgKiA+nD a/pwYI3vSqAcVXSMU/nk9og/KO2j2EOldjgvEtXOJtB5KNHY9KlxHmzo27gAfturhx/kDFB34GhzT oBDcgUbLsqW5CYUlDuPE6Xoq3Kyp/guKJDQZJRPUTJhkwpiISOMkqjIAbK86OlGHhTmd5NZc8EvJk NB2CrKHgAWEBm9Oh5Kr443jFIsjyBwUqpRTgtpYkZwyL2j2Vt423F22vQS0edydOqvAGuoeiZJ60H mjbhlzQEGaTIV9SD/pQWZi0ZGXF0QzizmM75rGCXC3xhZG9Zp0+1ucHurdOCZiFDXrNBC7df172Up Krqg/cd8w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcB9l-0007Ix-Lp; Mon, 09 Nov 2020 17:40:42 +0000 Received: from mail-db8eur05on2108.outbound.protection.outlook.com ([40.107.20.108] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcB98-00071i-Mg for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 17:40:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nkNTLSLofs9Saidu9U7tj1uWbPE8WCMXR58ZYyscfQ/xsBEDCX7/9HuPF7Z7U2QsggQ8zLLyoE+SjCTCj83rPlXUDiX34/FIU4fdpzUbR4HDOfspiHlcHk3L6caStM/QvcTe4oa6YE/Pgqu1z7r1YtB7SddLlgG8u+j8U0ysrcZdALRx42r4eHeCQkVM7Rq8oFyzDmWQbCjNYLChVm4ItoS3Y32yZaM3pH0DJk5U5zxi+Zq7kr3Isk+Vy4ceN8zveAQdsbQZB8dahqcT3ETMEi4vlTh4efaFDs/J5q4Q98cTLKYY3Klp5M5UPG2http8ZizZAC5YZoEgE38hGDOZhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ekBpxwXSVONW5QZmfSebcodwkrfrP31EZtizj5j+ryk=; b=kYSU8ahysmvElHya5NbwQ4WKcMr2f29YT9DsSOug+I8Figo7sgVqAHvuUKQsL2GoCMW9LOzlgGiEPro7DssUDiHYWPnb/ppRLiBL6HUH6KLmcZSGlPxsnpZOR8bEoFUNfO55ihJt7hWr99iQ7zuuh9xK3dmn0QLJZLasv4Hl2aQRZcHylZfqZ2sXPk5dOK545NmYAmTO6n9/TJmxAuptuy0cghP7z2WI2DVHcoBPn0FqHgOY1MHNCPVDYGLU3VlMoiZgp19p/4FPlIKBouZOdDcc+8moVNhmUs70vrzzZistylCpz2qJoJBmoBjzAhNc6x8nMO6qY3z04fiBwrokbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=voleatech.de; dmarc=pass action=none header.from=voleatech.de; dkim=pass header.d=voleatech.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=voleatech.de; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ekBpxwXSVONW5QZmfSebcodwkrfrP31EZtizj5j+ryk=; b=G/WgwGGFGFGkbz5MOc5NRKVLNA0BpHmcyj38a1r0oDJKri6EGOE7oJK1uUiSYDtBRP+aoZ4OtVOzY1tJ/fMKh6seyLE4hJZUhBkvwrtGjDHUfyibUlpmIKy7UhXDUJ4UV1JLb9dghNjQmqRfXGzTs9nWn3JsiR1jALreS3neapc= Authentication-Results: kernel.dk; dkim=none (message not signed) header.d=none;kernel.dk; dmarc=none action=none header.from=voleatech.de; Received: from AM8PR05MB7251.eurprd05.prod.outlook.com (2603:10a6:20b:1d4::23) by AM0PR05MB5362.eurprd05.prod.outlook.com (2603:10a6:208:ea::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Mon, 9 Nov 2020 17:39:53 +0000 Received: from AM8PR05MB7251.eurprd05.prod.outlook.com ([fe80::f132:2cc:34f2:5e4]) by AM8PR05MB7251.eurprd05.prod.outlook.com ([fe80::f132:2cc:34f2:5e4%7]) with mapi id 15.20.3541.025; Mon, 9 Nov 2020 17:39:53 +0000 From: sven.auhagen@voleatech.de To: axboe@kernel.dk, hdegoede@redhat.com, robh+dt@kernel.org, tglx@linutronix.de, maz@kernel.org, gregory.clement@bootlin.com Subject: [PATCH v3 3/9] ata: libahci_platform: Do not try to get an IRQ when AHCI_HFLAG_MULTI_MSI is set Date: Mon, 9 Nov 2020 18:39:42 +0100 Message-Id: <20201109173948.96663-4-sven.auhagen@voleatech.de> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20201109173948.96663-1-sven.auhagen@voleatech.de> References: <20201109173948.96663-1-sven.auhagen@voleatech.de> X-Originating-IP: [109.193.235.168] X-ClientProxiedBy: AM0PR04CA0135.eurprd04.prod.outlook.com (2603:10a6:208:55::40) To AM8PR05MB7251.eurprd05.prod.outlook.com (2603:10a6:20b:1d4::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (109.193.235.168) by AM0PR04CA0135.eurprd04.prod.outlook.com (2603:10a6:208:55::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Mon, 9 Nov 2020 17:39:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: db2aaf42-1665-4711-62dd-08d884d67779 X-MS-TrafficTypeDiagnostic: AM0PR05MB5362: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VNwms+2dghsoTI9SBcX7yDzxpVc481yQ1tiEY6Okhwlbf+K8bXJ7SM4iMA7hFMd6P8otn3QNGIJuFZnOzv4UtQZClQfbEKovs9AcJHYnuBvSGzk0RDpFTTyoISWnd7M80KbmRM2M+bHw7QIf1cIDRHLON+FoKGenCxeQeRlDBL6tHHLTkzZETbhzh1i3Zf8odbRJJ9VkcPsyJ0N9pWcexBlDY200GaLqqGYnthA+FOeshKM+FVdXBrlnDGaMEb/cPf6MMM0bBajmctU4K3DcSPXmXvF3Is73mcFSruWHOedQBDg57Ka7iLhx1C3arCyA9fBfW1J/aSpPyHyvR8hswrwtxvkvq9o/uAMssrwTsyrmJSCGGbLlYhWm94Cxns1y X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR05MB7251.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(396003)(136003)(366004)(39830400003)(52116002)(69590400008)(66946007)(5660300002)(1076003)(66476007)(66556008)(26005)(2906002)(478600001)(316002)(9686003)(6506007)(6512007)(86362001)(6666004)(16526019)(8936002)(956004)(4326008)(36756003)(7416002)(186003)(83380400001)(2616005)(8676002)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: oZ3lunCPTBezLqEHn5J8NQVT9Ahfpz759AK09Q96PG04pTTkmwf6qkvOijoy/xTNS8SwCEKye/WCBeDmXAqbkByBk/iYZ0xk+9x1byAiJz1L2liRhK6FNig+E9Hnnl+nqJaYpaG+uBTER4fWScCYaqFmbgDr+YixqmV9qgNoErGRmlEjyNojHtWBWEIA346IoSxWC9fOB8XieZ6Ufio8XPTdcgM2RiaOE2X8oN7HOBd6+bB0mjIp4wjr/NWkbNRa/wwia6oDJfUTssPC0iAjLmV1/dw70GfRW59/AW7M9ZSjLmemktbJAf+V854lvVU9N+yyV8uFh2ApjOBoYRiSLGDgIgv+7yh7tSVlAhM/Q0BkA/MT+hFX9+eWxqW9WQKEdd4dRbhYSTbnFkhylJbJglqWusmVHZowDefbJA6aGj7tx+n1qbYwwk/cvbtYCVAS/roYsPkCHGGXR9MQLvHtzcgaW9jKqOy4JeO2v4Z+eSa9OD6MXuOlsBO9XwJJYWeNeBMh0IdE4RMI6FKSXjw7cB0Z+cLFDQl4M2Eq6CHiJbZnL+ZcOReSVYp94yDKQgJMu9e+gQY6ojolzI39h636RXvFOkRHUVAEBkZHawSGZhR7ute7Ct73LPKYOBM7OxfHkPUgH2Pp88mZKFcca7/4+w== X-OriginatorOrg: voleatech.de X-MS-Exchange-CrossTenant-Network-Message-Id: db2aaf42-1665-4711-62dd-08d884d67779 X-MS-Exchange-CrossTenant-AuthSource: AM8PR05MB7251.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2020 17:39:53.6630 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b82a99f6-7981-4a72-9534-4d35298f847b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YqdszF7OohjbQ9F/P4JgQAi4HePimVSEbbu860f+aomUYa8UhvMrglFPPnnNk7XWgrksR+AmCIn4IGcFpNNw/FLwF1bpqK0w/3qgg1eGkNk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5362 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_124002_887082_9BE5C53D X-CRM114-Status: GOOD ( 12.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, jason@lakedaemon.net, devicetree@vger.kernel.org, antoine.tenart@bootlin.com, viresh.kumar@linaro.org, rjw@rjwysocki.net, maxime.chevallier@bootlin.com, linux-ide@vger.kernel.org, thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Sven Auhagen When the ahci-host AHCI_HFLAG_MULTI_MSI flag is set then the driver must provide a get_irq_vector callback and take care of getting the IRQs itself. So in this case ahci_platform_init_host() should not try to get an IRQ itself. Suggested-by: Hans de Goede Reviewed-by: Hans de Goede Signed-off-by: Sven Auhagen --- drivers/ata/libahci_platform.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c index de638dafce21..f6f2a111d226 100644 --- a/drivers/ata/libahci_platform.c +++ b/drivers/ata/libahci_platform.c @@ -581,14 +581,16 @@ int ahci_platform_init_host(struct platform_device *pdev, struct ata_host *host; int i, irq, n_ports, rc; - irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - if (irq != -EPROBE_DEFER) - dev_err(dev, "no irq\n"); - return irq; - } + if (!(hpriv->flags & AHCI_HFLAG_MULTI_MSI)) { + irq = platform_get_irq(pdev, 0); + if (irq <= 0) { + if (irq != -EPROBE_DEFER) + dev_err(dev, "no irq\n"); + return irq; + } - hpriv->irq = irq; + hpriv->irq = irq; + } /* prepare host */ pi.private_data = (void *)(unsigned long)hpriv->flags;