diff mbox series

[V2,4/5] arm64: dts: ti: k3-am654-base-board: Fix up un-necessary status set to "okay" for USB

Message ID 20201112014929.25227-5-nm@ti.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: ti: Cleanup mix of "okay" and "disabled" usage | expand

Commit Message

Nishanth Menon Nov. 12, 2020, 1:49 a.m. UTC
The default state of a device tree node is "okay". There is no specific
use of explicitly adding status = "okay" in the board dts.

Fixes: 7e7e7dd51d06 ("arm64: dts: ti: k3-am654-base-board: enable USB1")
Signed-off-by: Nishanth Menon <nm@ti.com>
Cc: Roger Quadros <rogerq@ti.com>
---
Changes since v1:
- no change.

v1: https://lore.kernel.org/linux-arm-kernel/20201104224356.18040-5-nm@ti.com/

 arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 8 --------
 1 file changed, 8 deletions(-)

Comments

Roger Quadros Nov. 12, 2020, 1:01 p.m. UTC | #1
On 12/11/2020 03:49, Nishanth Menon wrote:
> The default state of a device tree node is "okay". There is no specific
> use of explicitly adding status = "okay" in the board dts.
> 
> Fixes: 7e7e7dd51d06 ("arm64: dts: ti: k3-am654-base-board: enable USB1")
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Cc: Roger Quadros <rogerq@ti.com>

Acked-by: Roger Quadros <rogerq@ti.com>

cheers,
-roger
> ---
> Changes since v1:
> - no change.
> 
> v1: https://lore.kernel.org/linux-arm-kernel/20201104224356.18040-5-nm@ti.com/
> 
>   arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index 199c4d4e7539..744efcbb4f7f 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -325,14 +325,6 @@ &sdhci1 {
>   	disable-wp;
>   };
>   
> -&dwc3_1 {
> -	status = "okay";
> -};
> -
> -&usb1_phy {
> -	status = "okay";
> -};
> -
>   &usb1 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&usb1_pins_default>;
>
Tony Lindgren Nov. 12, 2020, 2:19 p.m. UTC | #2
* Roger Quadros <rogerq@ti.com> [201112 13:01]:
> On 12/11/2020 03:49, Nishanth Menon wrote:
> > The default state of a device tree node is "okay". There is no specific
> > use of explicitly adding status = "okay" in the board dts.
> > 
> > Fixes: 7e7e7dd51d06 ("arm64: dts: ti: k3-am654-base-board: enable USB1")
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > Cc: Roger Quadros <rogerq@ti.com>
> 
> Acked-by: Roger Quadros <rogerq@ti.com>

Reviewed-by: Tony Lindgren <tony@atomide.com>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
index 199c4d4e7539..744efcbb4f7f 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
@@ -325,14 +325,6 @@  &sdhci1 {
 	disable-wp;
 };
 
-&dwc3_1 {
-	status = "okay";
-};
-
-&usb1_phy {
-	status = "okay";
-};
-
 &usb1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&usb1_pins_default>;