From patchwork Fri Nov 13 13:49:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11903535 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC9EDC388F7 for ; Fri, 13 Nov 2020 13:52:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 588152078D for ; Fri, 13 Nov 2020 13:52:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DgZki2kw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sDMRPQsw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 588152078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CK87BtLAGiiJfAjsZxfm9E2gBzCm8LBCi2ydSYtgqCc=; b=DgZki2kwcRKoPvUsrf5901lTt 4xkQ4A2cSEr0jRrxkiMoXPHlzirHWmvrDG3bu9wSvDE15xTJO9b0tX6GHMar7aybFZvTSyfC7206F oTon7VB5zE32cP3h3M4akjjL0L4n7KqTfeacCmUJ342/UVzZnSmpK3IXx4hCf3A/wuOwglk1kq626 tvaGC99CSgj/uEV2BuIsc7Glug+LicqzDv6Jxx3djtxfTSv7A0Vre0jK76URuzA9tNHDYkdkAMdyZ BqE7ifT6xn1lO0z/XbDt054HZqvn2WgjV8W31bg6TGUcrdLaiWMzIc7IEgGYIlIWTnRMaouKCVuR3 PDPZ8WWeg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdZTx-0007mo-1k; Fri, 13 Nov 2020 13:51:17 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdZSc-000740-Hc for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2020 13:49:57 +0000 Received: by mail-wr1-x441.google.com with SMTP id 33so9980451wrl.7 for ; Fri, 13 Nov 2020 05:49:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pCTuXmjwQai/CDFPUzQ3kg8YDOVHQv+4DVCFDqYGwk4=; b=sDMRPQswWGSH++5S2Loy2vzVU6PKTlMKGyiB2LA3prnW76xMrNwZA0nmexJsaEobkL 38w/XO7PKggGRLVdb2wtak4X17JNVk35qD6R3pbK0i8q6LyutT3Iou5Y94lsl1k4blLz p2xkf3ETUNYs6hssfPEjjPlm89LkhETsVduJvbmkM3oEMJrW5ApTPE2MkFqTfGAQ5U5R w7ZuvayjNoZuO5u87vJsYPZsZ0HoKo43J0Vty3iLo3fpfA8NBAVzw4EFGH1TJZbsHJnA tvdmSrzbQTEsCnu2Izn1p6tYQRXU5QZq3hdTi8ApEpzNiZ6yyhAX2cc6OmgfC51eg6y8 0meA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pCTuXmjwQai/CDFPUzQ3kg8YDOVHQv+4DVCFDqYGwk4=; b=UjlN+fsViwdlyyzIw+9U/EGH8M5RdC5N/7kgPqEYGLcmvffPwE/v63A1zOBG2SIQjx OJKYfJLIYLvr6qEOHwe6ljzepD6Tf5xszAXvf4OVq4okUqkZsSHUTfDi1f/LFP45MNb/ MtoMKEpN7mFK2WRI7Yj0UwMRey7GotDB70amYkT+qUEIyIidPKEB8fL7Wtjc5yW4k5pe ZhSNL6eehVPYLJHneMIGN+fiTisOZcmdROuNlngUX7dOCB+61Xf/P5wrzJ61ZK7d/cRE OiTBeLgwUHmZ3LA+E1rk2N+TXaujCZJWY7Qcm7uDuaZMGqneA+q0QkS8bKN/QKvZmfAC ScBw== X-Gm-Message-State: AOAM5311Ooatv37tWDsimCt0hG9AF8Pp4d7pPxLubBMjOc72PPq0yFIY XpF9KXf5voxb2+VXeySkhgrFLA== X-Google-Smtp-Source: ABdhPJwC5dZ17zovLWTwBFMnjLJ/S6DTsonz5wBvHLFm45TRGQA1LxJ9EXZzT2BBh6sywylyM2FixA== X-Received: by 2002:a5d:654c:: with SMTP id z12mr3461026wrv.46.1605275393304; Fri, 13 Nov 2020 05:49:53 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id t11sm4561614wrm.8.2020.11.13.05.49.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 05:49:52 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 09/40] drm/mediatek/mtk_drm_crtc: Demote seriously out-of-date struct header Date: Fri, 13 Nov 2020 13:49:07 +0000 Message-Id: <20201113134938.4004947-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201113134938.4004947-1-lee.jones@linaro.org> References: <20201113134938.4004947-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201113_084954_940812_C151A60D X-CRM114-Status: GOOD ( 15.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This needs someone with in-depth knowledge of the driver to complete. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'pending_needs_vblank' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'event' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'layer_nr' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'pending_async_planes' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'cmdq_client' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'cmdq_event' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'hw_lock' not described in 'mtk_drm_crtc' Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Matthias Brugger Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 193848fd75154..bfe9942305435 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c @@ -24,7 +24,7 @@ #include "mtk_drm_gem.h" #include "mtk_drm_plane.h" -/** +/* * struct mtk_drm_crtc - MediaTek specific crtc structure. * @base: crtc object. * @enabled: records whether crtc_enable succeeded @@ -34,6 +34,8 @@ * @mutex: handle to one of the ten disp_mutex streams * @ddp_comp_nr: number of components in ddp_comp * @ddp_comp: array of pointers the mtk_ddp_comp structures used by this crtc + * + * TODO: Needs update: this header is missing a bunch of member descriptions. */ struct mtk_drm_crtc { struct drm_crtc base;