| Message ID | 20201117103022.2136527-6-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: shmobile: Remove IOMEM and static mappings | expand |
Hello! On 17.11.2020 13:30, Geert Uytterhoeven wrote: > Replace using the legacy IOMEM() macro to map the L2C registers by Mapping? Else it doesn't rhyme. ;-) > ioremap(). > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> [...] MBR, Sergei
Hi Sergei, On Wed, Nov 18, 2020 at 9:32 AM Sergei Shtylyov <sergei.shtylyov@gmail.com> wrote: > On 17.11.2020 13:30, Geert Uytterhoeven wrote: > > > Replace using the legacy IOMEM() macro to map the L2C registers by > > Mapping? Else it doesn't rhyme. ;-) Can you please elaborate? > > ioremap(). Gr{oetje,eeting}s, Geert
On 18.11.2020 11:44, Geert Uytterhoeven wrote: [...] >>> Replace using the legacy IOMEM() macro to map the L2C registers by >> >> Mapping? Else it doesn't rhyme. ;-) > > Can you please elaborate? Replace using ... to mapping ..., no? Or rather s/to/with/? >>> ioremap(). > > Gr{oetje,eeting}s, > > Geert MBR, Sergei
Hi Sergei, On Wed, Nov 18, 2020 at 9:50 AM Sergei Shtylyov <sergei.shtylyov@gmail.com> wrote: > On 18.11.2020 11:44, Geert Uytterhoeven wrote: > > [...] > >>> Replace using the legacy IOMEM() macro to map the L2C registers by > >> > >> Mapping? Else it doesn't rhyme. ;-) > > > > Can you please elaborate? > > Replace using ... to mapping ..., no? Or rather s/to/with/? > > >>> ioremap(). "to map" applies to "using". "by" applies to "replace" (replace A by B). Gr{oetje,eeting}s, Geert
diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c index cac92edd2b8879cc..d626bce83462c86e 100644 --- a/arch/arm/mach-shmobile/setup-sh73a0.c +++ b/arch/arm/mach-shmobile/setup-sh73a0.c @@ -44,7 +44,7 @@ static void __init sh73a0_generic_init(void) { #ifdef CONFIG_CACHE_L2X0 /* Shared attribute override enable, 64K*8way */ - l2x0_init(IOMEM(0xf0100000), 0x00400000, 0xc20f0fff); + l2x0_init(ioremap(0xf0100000, PAGE_SIZE), 0x00400000, 0xc20f0fff); #endif }
Replace using the legacy IOMEM() macro to map the L2C registers by ioremap(). Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- arch/arm/mach-shmobile/setup-sh73a0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)