| Message ID | 20201119174906.43862-4-cristian.marussi@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | SCMIv3.0 Sensor Extensions | expand |
Hi Guenter, On Thu, Nov 19, 2020 at 05:49:03PM +0000, Cristian Marussi wrote: > Use an int to calculate scale values inside scmi_hwmon_scale() to match > the updated scale data type in struct scmi_sensor_info. > You were not cc-ed in previous versions unfortunately. I plan to take this along with the rest of SCMI changes if you are fine with this change and provide Ack/Review. Sorry for the rush.
On Thu, Nov 19, 2020 at 05:49:03PM +0000, Cristian Marussi wrote: > Use an int to calculate scale values inside scmi_hwmon_scale() to match > the updated scale data type in struct scmi_sensor_info. > > Cc: linux-hwmon@vger.kernel.org > Cc: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> Acked-by: Guenter Roeck <linux@roeck-us.net> [ Assuming this will be pushed togesther with the other patches in the series ] Guenter > --- > drivers/hwmon/scmi-hwmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c > index 09ce30cba54b..17d064e58938 100644 > --- a/drivers/hwmon/scmi-hwmon.c > +++ b/drivers/hwmon/scmi-hwmon.c > @@ -30,7 +30,7 @@ static inline u64 __pow10(u8 x) > > static int scmi_hwmon_scale(const struct scmi_sensor_info *sensor, u64 *value) > { > - s8 scale = sensor->scale; > + int scale = sensor->scale; > u64 f; > > switch (sensor->type) { > -- > 2.17.1 >
On Sat, Nov 21, 2020 at 08:59:03AM -0800, Guenter Roeck wrote: > On Thu, Nov 19, 2020 at 05:49:03PM +0000, Cristian Marussi wrote: > > Use an int to calculate scale values inside scmi_hwmon_scale() to match > > the updated scale data type in struct scmi_sensor_info. > > > > Cc: linux-hwmon@vger.kernel.org > > Cc: Guenter Roeck <linux@roeck-us.net> > > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> > > Acked-by: Guenter Roeck <linux@roeck-us.net> > Thanks. > [ Assuming this will be pushed togesther with the other patches in the series ] > Yes I am planning to take as part of the series.
diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c index 09ce30cba54b..17d064e58938 100644 --- a/drivers/hwmon/scmi-hwmon.c +++ b/drivers/hwmon/scmi-hwmon.c @@ -30,7 +30,7 @@ static inline u64 __pow10(u8 x) static int scmi_hwmon_scale(const struct scmi_sensor_info *sensor, u64 *value) { - s8 scale = sensor->scale; + int scale = sensor->scale; u64 f; switch (sensor->type) {
Use an int to calculate scale values inside scmi_hwmon_scale() to match the updated scale data type in struct scmi_sensor_info. Cc: linux-hwmon@vger.kernel.org Cc: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> --- drivers/hwmon/scmi-hwmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)