From patchwork Mon Nov 23 17:47:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Sampson X-Patchwork-Id: 11925869 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2161AC63697 for ; Mon, 23 Nov 2020 17:48:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1F3E206B2 for ; Mon, 23 Nov 2020 17:48:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sL4/uyHu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1F3E206B2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=offog.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=fx0Pc0W61F6QF1b7Tp/8IJP2fcuIhjS+2zrXCyJSt1g=; b=sL4/uyHuJPD8E0dsEAT6eGI2Nn ch27wmPiKDlb5xAPpmV4KaEstnAUOnm1FwxrQ4ImBo7RmCWyKYT+XxulbbZD/cV7VG15q6/9Qj8wE qpnFeKEjNN8beYZgzNRK7gwvwqGMQ7eIvzUGfuISNyVDeq+6iIKmBUMdG9jSvJBh40xfglUiZk2VE 9znpIAR1yCd8W2SSmRwdxoSousrSpY/8/bAkOl6KXrmJmuuXdqe9wonWVNkx90Qv6Nhx4dCBdHApT ufafbsneG+xvLEQDW4ktrrhz42uH+8xWhAU2BKQwLAqGUFgwKNEvaPx0pye8ZyKT6aAxn+klWp4k7 tkWBeaRA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khFwu-0004f1-88; Mon, 23 Nov 2020 17:48:24 +0000 Received: from b-painless.mh.aa.net.uk ([2001:8b0:0:30::52]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khFwr-0004eJ-1z for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 17:48:21 +0000 Received: from cartman.offog.org ([2001:8b0:83b:b53f::a]) by b-painless.mh.aa.net.uk with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khFwq-0004YD-6M; Mon, 23 Nov 2020 17:48:20 +0000 Received: from ats by cartman.offog.org with local (Exim 4.92.3) (envelope-from ) id 1khFwY-0001pI-3Q; Mon, 23 Nov 2020 17:48:02 +0000 From: Adam Sampson To: Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Adam Sampson , linux-sunxi , devicetree , linux-arm-kernel , Andrew Lunn Subject: [PATCH] ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY Date: Mon, 23 Nov 2020 17:47:39 +0000 Message-Id: <20201123174739.6809-1-ats@offog.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_124821_112449_7E4BA760 X-CRM114-Status: GOOD ( 14.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chen-Yu Tsai Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The RX/TX delays for the Ethernet PHY on the Linksprite pcDuino 3 Nano are configured in hardware, using resistors that are populated to pull the RTL8211E's RXDLY/TXDLY pins low or high as needed. phy-mode should be set to rgmii-id to reflect this. Previously it was set to rgmii, which used to work but now results in the delays being disabled again as a result of the bugfix in commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config"). Tested on two pcDuino 3 Nano boards purchased in 2015. Without this fix, Ethernet works unreliably on one board and doesn't work at all on the other. Fixes: 061035d456c9 ("ARM: dts: sun7i: Add dts file for pcDuino 3 Nano board") Signed-off-by: Adam Sampson Reviewed-by: Andrew Lunn Acked-by: Chen-Yu Tsai --- arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts b/arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts index fce2f7fcd084..bf38c66c1815 100644 --- a/arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts +++ b/arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts @@ -1,5 +1,5 @@ /* - * Copyright 2015 Adam Sampson + * Copyright 2015-2020 Adam Sampson * * This file is dual-licensed: you can use it either under the terms * of the GPL or the X11 license, at your option. Note that this dual @@ -115,7 +115,7 @@ &gmac { pinctrl-names = "default"; pinctrl-0 = <&gmac_rgmii_pins>; phy-handle = <&phy1>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; status = "okay"; };