| Message ID | 20201203225418.1477560-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | phy: mediatek: allow compile-testing the hdmi phy | expand |
On Thu, 2020-12-03 at 23:54 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Compile-testing the DRM_MEDIATEK_HDMI driver leads to a harmless > warning: > > WARNING: unmet direct dependencies detected for PHY_MTK_HDMI > Depends on [n]: ARCH_MEDIATEK [=n] && OF [=y] > Selected by [y]: > - DRM_MEDIATEK_HDMI [=y] && HAS_IOMEM [=y] && DRM_MEDIATEK [=y] > > The driver builds fine, so allow compile-testing it as well > to get rid of the warning. > > Fixes: b28be59a2e26 ("phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/phy/mediatek/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig > index 65ed26e40c9f..29a85b2738f8 100644 > --- a/drivers/phy/mediatek/Kconfig > +++ b/drivers/phy/mediatek/Kconfig > @@ -40,7 +40,9 @@ config PHY_MTK_XSPHY > > config PHY_MTK_HDMI > tristate "MediaTek HDMI-PHY Driver" > - depends on ARCH_MEDIATEK && OF > + depends on ARCH_MEDIATEK || COMPILE_TEST > + depends on COMMON_CLK Seems no need add COMMON_CLK here > + depends on OF > select GENERIC_PHY > help > Support HDMI PHY for Mediatek SoCs.
On Fri, Dec 4, 2020 at 2:47 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: > > diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig > > index 65ed26e40c9f..29a85b2738f8 100644 > > --- a/drivers/phy/mediatek/Kconfig > > +++ b/drivers/phy/mediatek/Kconfig > > @@ -40,7 +40,9 @@ config PHY_MTK_XSPHY > > > > config PHY_MTK_HDMI > > tristate "MediaTek HDMI-PHY Driver" > > - depends on ARCH_MEDIATEK && OF > > + depends on ARCH_MEDIATEK || COMPILE_TEST > > + depends on COMMON_CLK > Seems no need add COMMON_CLK here My mistake, I had squashed two build fixes for the same driver but forgot to update the changelog with the other output. This is what happens without CONFIG_COMMON_CLK: arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi.o: in function `mtk_hdmi_phy_probe': phy-mtk-hdmi.c:(.text+0xd8): undefined reference to `__clk_get_name' arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x12c): undefined reference to `devm_clk_register' arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x250): undefined reference to `of_clk_add_provider' arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x298): undefined reference to `of_clk_src_simple_get' I'll resend with that added in. Arnd
diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig index 65ed26e40c9f..29a85b2738f8 100644 --- a/drivers/phy/mediatek/Kconfig +++ b/drivers/phy/mediatek/Kconfig @@ -40,7 +40,9 @@ config PHY_MTK_XSPHY config PHY_MTK_HDMI tristate "MediaTek HDMI-PHY Driver" - depends on ARCH_MEDIATEK && OF + depends on ARCH_MEDIATEK || COMPILE_TEST + depends on COMMON_CLK + depends on OF select GENERIC_PHY help Support HDMI PHY for Mediatek SoCs.