diff mbox series

clk: imx: fix build failure on i.MX SCU clk

Message ID 20201203230756.1481397-1-arnd@kernel.org (mailing list archive)
State New, archived
Headers show
Series clk: imx: fix build failure on i.MX SCU clk | expand

Commit Message

Arnd Bergmann Dec. 3, 2020, 11:07 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

When CONFIG_MXC_CLK_SCU is enabled, but CONFIG_CLK_IMX8QXP is not,
the kernel fails to link with:

aarch64-linux-ld: no input files
make[5]: *** [scripts/Makefile.build:434: drivers/clk/imx/clk-imx-scu.o] Error 1
aarch64-linux-ld: no input files
make[5]: *** [scripts/Makefile.build:434: drivers/clk/imx/clk-imx-lpcg-scu.o] Error 1

The only sensible configuration at the moment is to have both mean
the same thing, so make hide the first one to avoid broken
configurations.

Fixes: e0d0d4d86c76 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Reported-by: Anders Roxell <anders.roxell@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/clk/imx/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Stephen Boyd Dec. 5, 2020, 5:41 a.m. UTC | #1 
Quoting Arnd Bergmann (2020-12-03 15:07:52)
> From: Arnd Bergmann <arnd@arndb.de>
> 
> When CONFIG_MXC_CLK_SCU is enabled, but CONFIG_CLK_IMX8QXP is not,
> the kernel fails to link with:
> 
> aarch64-linux-ld: no input files
> make[5]: *** [scripts/Makefile.build:434: drivers/clk/imx/clk-imx-scu.o] Error 1
> aarch64-linux-ld: no input files
> make[5]: *** [scripts/Makefile.build:434: drivers/clk/imx/clk-imx-lpcg-scu.o] Error 1
> 
> The only sensible configuration at the moment is to have both mean
> the same thing, so make hide the first one to avoid broken
> configurations.
> 
> Fixes: e0d0d4d86c76 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
> Reported-by: Anders Roxell <anders.roxell@linaro.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Dong sent something similar at
https://lore.kernel.org/r/20201130084624.21113-1-aisheng.dong@nxp.com
diff mbox series

Patch

diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
index 3b393cb07295..47d9ec3abd2f 100644
--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig
@@ -5,9 +5,7 @@  config MXC_CLK
 	depends on ARCH_MXC || COMPILE_TEST
 
 config MXC_CLK_SCU
-	tristate "IMX SCU clock"
-	depends on ARCH_MXC || COMPILE_TEST
-	depends on IMX_SCU && HAVE_ARM_SMCCC
+	tristate
 
 config CLK_IMX1
 	def_bool SOC_IMX1