diff mbox series

[3/5] remoteproc: pru: Deny rproc sysfs ops for PRU client driven boots

Message ID 20201211142933.25784-4-grzegorz.jaszczyk@linaro.org (mailing list archive)
State New, archived
Headers show
Series Introduce PRU remoteproc consumer API | expand

Commit Message

Grzegorz Jaszczyk Dec. 11, 2020, 2:29 p.m. UTC
From: Suman Anna <s-anna@ti.com>

The PRU remoteproc driver is not configured for 'auto-boot' by default,
and allows to be booted either by in-kernel PRU client drivers or by
userspace using the generic remoteproc sysfs interfaces. The sysfs
interfaces should not be permitted to change the remoteproc firmwares
or states when a PRU is being managed by an in-kernel client driver.
Use the newly introduced remoteproc generic 'deny_sysfs_ops' flag to
provide these restrictions by setting and clearing it appropriately
during the PRU acquire and release steps.

Signed-off-by: Suman Anna <s-anna@ti.com>
Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
 drivers/remoteproc/pru_rproc.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series


diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
index cc2e585778b1..bfb53967edda 100644
--- a/drivers/remoteproc/pru_rproc.c
+++ b/drivers/remoteproc/pru_rproc.c
@@ -228,6 +228,7 @@  struct rproc *pru_rproc_get(struct device_node *np, int index,
 	pru->client_np = np;
+	rproc->deny_sysfs_ops = true;
@@ -258,6 +259,7 @@  void pru_rproc_put(struct rproc *rproc)
 	pru->client_np = NULL;
+	rproc->deny_sysfs_ops = false;