From patchwork Mon Dec 21 08:35:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 11984351 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE395C433E0 for ; Mon, 21 Dec 2020 08:38:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B32722BF3 for ; Mon, 21 Dec 2020 08:38:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B32722BF3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l0Mi8P2nbF2c+wyNCE/SMBsFH8LN4o7E31q4j+O0Gls=; b=lVZqszQTxINSzviohWzM/zjB8Z FUB0xUjG5nEj0RZzH+uBZR1YtSoo4IMaT5eUckiyf/RIyQPYAOpBjLDkPNQIROPjFhzgLf1cO8P5e nhai27txzk4vCbDU/06klCCzUCmkf14f78zOUx+MbFR6r4VXSZe0wc2Xj+FFBkCjTioM7phjSk2u/ kVcCnyFTljVyhDeD9RICBnP83IVxwG3AgnY8yeqWdGPRXsNP71lFjSMVfTG0iLlqjdzNQRxXJyj5g 03Mbkcd6C5RbQikgih+OHSvPZAuJNMnxUMUIeM8GSgtVs1AivaaF3CChGTDBJyjHTNpq+QJ/WMJEN AQD+iBGw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krGhS-00009G-9n; Mon, 21 Dec 2020 08:37:50 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krGh0-0008SE-Uz for linux-arm-kernel@lists.infradead.org; Mon, 21 Dec 2020 08:37:24 +0000 Received: by mail-pj1-x102b.google.com with SMTP id m5so6031288pjv.5 for ; Mon, 21 Dec 2020 00:37:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qC/KW84FKO1uWhq/iQKC4RiY953AolFLy2isLyLZ8NU=; b=vDLV4T67hukz2oUaAa1PZI+7ZJ5RWYBI8jxvfsQm7BqJAaysxlklN3BMcW/yrwqqZF ku43TiGnv6Q5splpxewS9S/gSbL/hf9scarV/rD9Cqay2CWD8E6F1pefrx8gHGQkgiD7 +nF3+1Qr9ClrHts2Qytx2rulMU/VBfbnhRGkR3nGjkdPYRWoXebPnX4vPyzLf1Wu3eoK 4lVC7PIknGcf+jraTOnruEf+LCoCq4XqsKZnKlplrmdIIBvsyVi8QKPnsVv4DsVK1w8G 7iFSMVAgPoK6gi3tLM7KKWgqBQ8a/E6L7YX0Ot2gcA74guf2jJ0686L33Op//3jPK9X/ twbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qC/KW84FKO1uWhq/iQKC4RiY953AolFLy2isLyLZ8NU=; b=jFZNCDt6/Yd8sKP5mG6/Hz8TwhAvc96dXYTnp7mD2gUCOS4JiJaICxCLmBcgDAuzAu kGm2MzTHSoybwA1UWih4VfE2HFPKRQdfa/IsGwzleB8vjjcRWHSXWii1ii5XS7lqXObJ EilzhzNwVrvBKIIAJU8Jsd/u4c72Pa+zPrZZ67J2LmBdAxfDl7fq+mKs50Y6VIRAsvYK y8rKKwFd/MF6y7cd77fVzrPhLVFXIs+g1thcSVS6H5QIVJQey6LVxdDFnbgXuN1YmwZL PYBpMPQPPxWp83QHeGKUjWfWOx7ORK5bGns9V/WoIHun8fRPcD/Q2HV4HjvBbgZXGQF7 6rug== X-Gm-Message-State: AOAM533twrrQyG6ZxPcPyAjw9pYLpg++JpHCtgfMf+BXX3Xkb3OXkq5J X2zGsN7O+KwCLhPeFzqcrejl6g== X-Google-Smtp-Source: ABdhPJwMhcaqiDCjJnO9qL88BjjIIl3m/LvWB3vcbRFpwq9cI6Z3pS+rP1nmveSeTumqt9WmLvMTEA== X-Received: by 2002:a17:90a:77c1:: with SMTP id e1mr16499862pjs.141.1608539841122; Mon, 21 Dec 2020 00:37:21 -0800 (PST) Received: from localhost ([45.137.216.7]) by smtp.gmail.com with ESMTPSA id r68sm15829563pfr.113.2020.12.21.00.37.20 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Dec 2020 00:37:20 -0800 (PST) From: Leo Yan To: Arnaldo Carvalho de Melo , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Ian Rogers , James Clark , Dave Martin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 7/7] perf arm-spe: Don't wait for PERF_RECORD_EXIT event Date: Mon, 21 Dec 2020 16:35:57 +0800 Message-Id: <20201221083557.27642-8-leo.yan@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201221083557.27642-1-leo.yan@linaro.org> References: <20201221083557.27642-1-leo.yan@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201221_033723_117836_AED988AA X-CRM114-Status: GOOD ( 16.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Yan MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When decode Arm SPE trace, it waits for PERF_RECORD_EXIT event (the last perf event) for processing trace data, which is needless and even might cause logic error, e.g. it might fail to correlate perf events with Arm SPE events correctly. So this patch removes the condition checking for PERF_RECORD_EXIT event. Signed-off-by: Leo Yan --- tools/perf/util/arm-spe.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c index 6bf2e4ff5342..7b7812eea117 100644 --- a/tools/perf/util/arm-spe.c +++ b/tools/perf/util/arm-spe.c @@ -636,11 +636,7 @@ static int arm_spe_process_event(struct perf_session *session, sample->time); } } else if (timestamp) { - if (event->header.type == PERF_RECORD_EXIT) { - err = arm_spe_process_queues(spe, timestamp); - if (err) - return err; - } + err = arm_spe_process_queues(spe, timestamp); } return err;