From patchwork Sat Jan 9 11:26:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Brugger X-Patchwork-Id: 12008135 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BA4AC433DB for ; Sat, 9 Jan 2021 11:28:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14E4C23A23 for ; Sat, 9 Jan 2021 11:28:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14E4C23A23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L/45iCj6DJVzJmrH//xs1/FLeJwcYIib/bkKPU8b5ds=; b=2bNFicYWolmuwpNorw3/LtUbb a7xQGbj17EPX10hkru/DUOt7XdD4mZzHZgEqjVpbt75FjsdXRIKdFqmbVGJsULf4K/6OChI6uiAwm KNb5JtK+6xydB6NWMjTKdqBCXJUk7gRU/RSVOSQX67eN/ffGu9TaWSfSdA4erlOC71gg2XiaULejm J6BT1N/EYO4FdGJ1Bc+qcoWOOLZjxLycVicrVHMZtFvzwJba3mVVyclZ12hkZ2ZLlFbjZ9xpW/hEl 8E9ay2FsHrOSuSuO3uekkwPaRGmS52L8zKx0ib/hbrHnoAak8cPLo+J9Xkj/24hX/0BPoY6d5syD6 i48Pt0TMw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyCOB-0008Cz-PB; Sat, 09 Jan 2021 11:26:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyCNx-00087w-Dv; Sat, 09 Jan 2021 11:26:22 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 424F123A58; Sat, 9 Jan 2021 11:26:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610191580; bh=6GN7kj+RoSZ2m6uLCL8sHki+5OJWmv4cnpxhwevCVRA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KGmINWBjz8c2GpjrFDL6ZZ2f9Dn4P8DCj1G1xmdvlDyjtT3ySCXyGtQ7BPqo+4VUw FvozlS555RlT0QbFq9ZCDsBsmSJJw2dmJtN98qHl9zuYnc6wuuHtOJ1JkOL5YFoVel pqeCc8U1Eig5Fcs0GFX95DYhIcu6NCnlT7GeCLr7i1TkCQhUJQpWhaVPnr8JOxBpjX 5rzsuVqgFVgaZaCojVfgA+8z8w4e+05wZICYYa3afcczl7gnzwJgJU930VIcQNkWqW Ijb+XaDuI8aPOSkoDaJ9X6wI7wXXjQB4RPxeORPldX9SDDJEXqdJa0GAVQrEAJBTBI BVmZ2cxtd5KiA== From: matthias.bgg@kernel.org To: Liam Girdwood , Mark Brown Subject: [PATCH v2 2/3] regulator: mt6358: Add OF match table Date: Sat, 9 Jan 2021 12:26:10 +0100 Message-Id: <20210109112612.1221-2-matthias.bgg@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210109112612.1221-1-matthias.bgg@kernel.org> References: <20210109112612.1221-1-matthias.bgg@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210109_062621_628140_95525B04 X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gene Chen , Matthias Brugger , Axel Lin , Matti Vaittinen , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , Chen Zhong , Hsin-Hsiung Wang Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Matthias Brugger The binding documentation mentions that a compatible is required for the MT6358 device node. But the driver does not provide a OF match table. This way auto-loading is broken as the MFD driver that registers the device has a .of_compatible set which makes the platform .uevent callback report a OF modalias, but that's not in the module. Fixes: f67ff1bd58f0 ("regulator: mt6358: Add support for MT6358 regulator") Signed-off-by: Matthias Brugger --- Changes in v2: - check for CONFIG_OF - add Fixes tag drivers/regulator/mt6358-regulator.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/regulator/mt6358-regulator.c b/drivers/regulator/mt6358-regulator.c index 13cb6ac9a892..a4ed19a54ec6 100644 --- a/drivers/regulator/mt6358-regulator.c +++ b/drivers/regulator/mt6358-regulator.c @@ -534,9 +534,18 @@ static const struct platform_device_id mt6358_platform_ids[] = { }; MODULE_DEVICE_TABLE(platform, mt6358_platform_ids); +#ifdef CONFIG_OF +static const struct of_device_id mt6358_of_match[] = { + { .compatible = "mediatek,mt6358-regulator", }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, mt6358_of_match); +#endif + static struct platform_driver mt6358_regulator_driver = { .driver = { .name = "mt6358-regulator", + .of_match_table = of_match_ptr(mt6358_of_match), }, .probe = mt6358_regulator_probe, .id_table = mt6358_platform_ids,