diff mbox series

firmware: arm_scmi: fix call site of notifications exit

Message ID 20210112191326.29091-1-cristian.marussi@arm.com (mailing list archive)
State New, archived
Headers show
Series firmware: arm_scmi: fix call site of notifications exit | expand

Commit Message

Cristian Marussi Jan. 12, 2021, 7:13 p.m. UTC
Call scmi_notification_exit() only when SCMI platform driver instance has
been really successfully removed.

Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
A small fix spotted by code inspection, applies on for-next/scmi
n top of:

commit 6054d97ab512 ("MAINTAINERS: Update ARM SCMI entry")
---
 drivers/firmware/arm_scmi/driver.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Sudeep Holla Jan. 13, 2021, 10:22 a.m. UTC | #1
On Tue, Jan 12, 2021 at 07:13:26PM +0000, Cristian Marussi wrote:
> Call scmi_notification_exit() only when SCMI platform driver instance has
> been really successfully removed.
>

Doesn't this deserve Fixes tag BTW ? Just send the tag if required, I can
fold it in.
Cristian Marussi Jan. 13, 2021, 10:43 a.m. UTC | #2
On Wed, Jan 13, 2021 at 10:22:54AM +0000, Sudeep Holla wrote:
> On Tue, Jan 12, 2021 at 07:13:26PM +0000, Cristian Marussi wrote:
> > Call scmi_notification_exit() only when SCMI platform driver instance has
> > been really successfully removed.
> >
> 
> Doesn't this deserve Fixes tag BTW ? Just send the tag if required, I can
> fold it in.

Yes, sorry

Fixes: 6b8a69131dc63 ("firmware: arm_scmi: Enable notification core")

Thanks

Cristian

> 
> -- 
> Regards,
> Sudeep
diff mbox series

Patch

diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index 5392e1fc6b4e..dd65fb1c453c 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -848,13 +848,13 @@  static int scmi_remove(struct platform_device *pdev)
 	struct scmi_info *info = platform_get_drvdata(pdev);
 	struct idr *idr = &info->tx_idr;
 
-	scmi_notification_exit(&info->handle);
-
 	mutex_lock(&scmi_list_mutex);
-	if (info->users)
+	if (info->users) {
 		ret = -EBUSY;
-	else
+	} else {
+		scmi_notification_exit(&info->handle);
 		list_del(&info->node);
+	}
 	mutex_unlock(&scmi_list_mutex);
 
 	if (ret)