diff mbox series

[12/19] ARM: dts: sun8i-s3: impetus: Fix the USB PHY ID detect GPIO properties

Message ID 20210114113538.1233933-12-maxime@cerno.tech (mailing list archive)
State New, archived
Headers show
Series [01/19] dt-bindings: sunxi: Fix the pinecube compatible | expand

Commit Message

Maxime Ripard Jan. 14, 2021, 11:35 a.m. UTC 
While the USB PHY Device Tree mandates that the name of the ID detect pin
should be usb0_id_det-gpios, a significant number of device tree use
usb0_id_det-gpio instead.

This was functional because the GPIO framework falls back to the gpio
suffix that is legacy, but we should fix this.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jernej Škrabec Jan. 14, 2021, 8:39 p.m. UTC | #1 
Dne četrtek, 14. januar 2021 ob 12:35:31 CET je Maxime Ripard napisal(a):
> While the USB PHY Device Tree mandates that the name of the ID detect pin
> should be usb0_id_det-gpios, a significant number of device tree use
> usb0_id_det-gpio instead.
> 
> This was functional because the GPIO framework falls back to the gpio
> suffix that is legacy, but we should fix this.
> 
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---

Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>

Best regards,
Jernej
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
index 24d507cdbcf9..052b010a5607 100644
--- a/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
+++ b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
@@ -39,6 +39,6 @@  &usb_otg {
 };
 
 &usbphy {
-	usb0_id_det-gpio = <&pio 5 6 GPIO_ACTIVE_HIGH>;
+	usb0_id_det-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
 	status = "okay";
 };