diff mbox series

[v5,2/4] ARM: hisi: add support for Kunpeng50x SoC

Message ID 20210116032740.873-3-thunder.leizhen@huawei.com (mailing list archive)
State New, archived
Headers show
Series ARM: Add support for Hisilicon Kunpeng L3 cache controller | expand

Commit Message

Zhen Lei Jan. 16, 2021, 3:27 a.m. UTC
Enable support for the Hisilicon Kunpeng506 and Kunpeng509 SoC.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 arch/arm/mach-hisi/Kconfig | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Arnd Bergmann Jan. 28, 2021, 2:28 p.m. UTC | #1
On Sat, Jan 16, 2021 at 4:32 AM Zhen Lei <thunder.leizhen@huawei.com> wrote:
>
> Enable support for the Hisilicon Kunpeng506 and Kunpeng509 SoC.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  arch/arm/mach-hisi/Kconfig | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig
> index 2e980f834a6aa1b..c724acc5c642b97 100644
> --- a/arch/arm/mach-hisi/Kconfig
> +++ b/arch/arm/mach-hisi/Kconfig
> @@ -55,6 +55,14 @@ config ARCH_HIX5HD2
>         help
>           Support for Hisilicon HIX5HD2 SoC family
>
> +config ARCH_KUNPENG50X
> +       bool "Hisilicon Kunpeng50x family"
> +       depends on ARCH_MULTI_V7
> +       select ARCH_FLATMEM_ENABLE
> +       select ARCH_HAS_HOLES_MEMORYMODEL if SPARSEMEM

I think the two 'select' statements are both wrong, though for
different reasons:

- ARCH_FLATMEM_ENABLE is already selected by ARCH_MULTIPLATFORM,
  and is something that should not be platform specific

- ARCH_HAS_HOLES_MEMORYMODEL was removed in v5.11,
  and should also not be selected by a platform.

Otherwise, this seems fine.

         Arnd
Zhen Lei Jan. 29, 2021, 8:09 a.m. UTC | #2
On 2021/1/28 22:28, Arnd Bergmann wrote:
> On Sat, Jan 16, 2021 at 4:32 AM Zhen Lei <thunder.leizhen@huawei.com> wrote:
>>
>> Enable support for the Hisilicon Kunpeng506 and Kunpeng509 SoC.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>>  arch/arm/mach-hisi/Kconfig | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig
>> index 2e980f834a6aa1b..c724acc5c642b97 100644
>> --- a/arch/arm/mach-hisi/Kconfig
>> +++ b/arch/arm/mach-hisi/Kconfig
>> @@ -55,6 +55,14 @@ config ARCH_HIX5HD2
>>         help
>>           Support for Hisilicon HIX5HD2 SoC family
>>
>> +config ARCH_KUNPENG50X
>> +       bool "Hisilicon Kunpeng50x family"
>> +       depends on ARCH_MULTI_V7
>> +       select ARCH_FLATMEM_ENABLE
>> +       select ARCH_HAS_HOLES_MEMORYMODEL if SPARSEMEM
> 
> I think the two 'select' statements are both wrong, though for
> different reasons:
> 
> - ARCH_FLATMEM_ENABLE is already selected by ARCH_MULTIPLATFORM,
>   and is something that should not be platform specific

Right. I will drop it.

> 
> - ARCH_HAS_HOLES_MEMORYMODEL was removed in v5.11,
>   and should also not be selected by a platform.

Thanks. I will drop it.

> 
> Otherwise, this seems fine.
> 
>          Arnd
> 
> .
>
diff mbox series

Patch

diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig
index 2e980f834a6aa1b..c724acc5c642b97 100644
--- a/arch/arm/mach-hisi/Kconfig
+++ b/arch/arm/mach-hisi/Kconfig
@@ -55,6 +55,14 @@  config ARCH_HIX5HD2
 	help
 	  Support for Hisilicon HIX5HD2 SoC family
 
+config ARCH_KUNPENG50X
+	bool "Hisilicon Kunpeng50x family"
+	depends on ARCH_MULTI_V7
+	select ARCH_FLATMEM_ENABLE
+	select ARCH_HAS_HOLES_MEMORYMODEL if SPARSEMEM
+	help
+	  Support for Hisilicon Kunpeng506 and Kunpeng509 SoC family
+
 config ARCH_SD5203
 	bool "Hisilicon SD5203 family"
 	depends on ARCH_MULTI_V5