diff mbox series

[v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node

Message ID 20210121170836.GA4948@lemon.iwr.uni-heidelberg.de (mailing list archive)
State New, archived
Headers show
Series [v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node | expand

Commit Message

Hermann Lauer Jan. 21, 2021, 5:08 p.m. UTC
BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high
packet loss rates. The realtek phy driver overrides the settings of the
pull ups for the delays, so fix this for Banana Pro.

Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de>
---
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jernej Skrabec Jan. 21, 2021, 7:54 p.m. UTC | #1
Dne četrtek, 21. januar 2021 ob 18:08:36 CET je Hermann Lauer napisal(a):
> BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high
> packet loss rates. The realtek phy driver overrides the settings of the
> pull ups for the delays, so fix this for Banana Pro.
> 
> Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de>

Much better. Now the only thing missing is "Fixes" tag, which references 
commit which introduced the issue. Probably this will be the commit which 
added ethernet node. This tag is important for deciding which commits should 
be backported to stable releases. Take a look in v1 for M2U fixes tag.

Btw, each version should have changelog under "---" line, so maintainers and 
reviewers know what changed.

Best regards,
Jernej
Chen-Yu Tsai Jan. 22, 2021, 3:09 a.m. UTC | #2
On Fri, Jan 22, 2021 at 3:54 AM Jernej Škrabec <jernej.skrabec@siol.net> wrote:
>
> Dne četrtek, 21. januar 2021 ob 18:08:36 CET je Hermann Lauer napisal(a):
> > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high
> > packet loss rates. The realtek phy driver overrides the settings of the
> > pull ups for the delays, so fix this for Banana Pro.
> >
> > Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de>
>
> Much better. Now the only thing missing is "Fixes" tag, which references
> commit which introduced the issue. Probably this will be the commit which
> added ethernet node. This tag is important for deciding which commits should
> be backported to stable releases. Take a look in v1 for M2U fixes tag.
>
> Btw, each version should have changelog under "---" line, so maintainers and
> reviewers know what changed.

The subject line should also be more concise. "Fix ethernet phy-mode" reads
much better than "Fix ethernet node", which could mean a number of things.

ChenYu
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/sun7i-a20-bananapro.dts b/arch/arm/boot/dts/sun7i-a20-bananapro.dts
--- a/arch/arm/boot/dts/sun7i-a20-bananapro.dts
+++ b/arch/arm/boot/dts/sun7i-a20-bananapro.dts
@@ -110,7 +110,7 @@ 
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac_rgmii_pins>;
 	phy-handle = <&phy1>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-supply = <&reg_gmac_3v3>;
 	status = "okay";
 };