diff mbox series

[next,v2,03/17] dt-bindings: phy: mediatek: dsi-phy: modify compatible dependence

Message ID 20210122120323.4337-3-chunfeng.yun@mediatek.com (mailing list archive)
State New, archived
Headers show
Series [next,v2,01/17] dt-bindings: usb: fix yamllint check warning | expand

Commit Message

Chunfeng Yun Jan. 22, 2021, 12:03 p.m. UTC
The compatilbe "mediatek,mt7623-mipi-tx" is not supported in driver,
and in fact uses "mediatek,mt2701-mipi-tx" instead on MT7623, so changes
the compatible items to make dependence clear.

Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2: separate two patches suggested by CK
---
 .../devicetree/bindings/phy/mediatek,dsi-phy.yaml   | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

Comments

Chun-Kuang Hu Jan. 24, 2021, 4:47 a.m. UTC | #1
Hi, Chunfeng:

Chunfeng Yun <chunfeng.yun@mediatek.com> 於 2021年1月22日 週五 下午8:04寫道:
>
> The compatilbe "mediatek,mt7623-mipi-tx" is not supported in driver,
> and in fact uses "mediatek,mt2701-mipi-tx" instead on MT7623, so changes
> the compatible items to make dependence clear.

Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>

>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v2: separate two patches suggested by CK
> ---
>  .../devicetree/bindings/phy/mediatek,dsi-phy.yaml   | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> index 71d4acea1f66..6e4d795f9b02 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> @@ -19,11 +19,14 @@ properties:
>      pattern: "^dsi-phy@[0-9a-f]+$"
>
>    compatible:
> -    enum:
> -      - mediatek,mt2701-mipi-tx
> -      - mediatek,mt7623-mipi-tx
> -      - mediatek,mt8173-mipi-tx
> -      - mediatek,mt8183-mipi-tx
> +    oneOf:
> +      - items:
> +          - enum:
> +              - mediatek,mt7623-mipi-tx
> +          - const: mediatek,mt2701-mipi-tx
> +      - const: mediatek,mt2701-mipi-tx
> +      - const: mediatek,mt8173-mipi-tx
> +      - const: mediatek,mt8183-mipi-tx
>
>    reg:
>      maxItems: 1
> --
> 2.18.0
Chun-Kuang Hu Jan. 24, 2021, 4:56 a.m. UTC | #2
Hi, Chunfeng:

Chun-Kuang Hu <chunkuang.hu@kernel.org> 於 2021年1月24日 週日 下午12:47寫道:
>
> Hi, Chunfeng:
>
> Chunfeng Yun <chunfeng.yun@mediatek.com> 於 2021年1月22日 週五 下午8:04寫道:
> >
> > The compatilbe "mediatek,mt7623-mipi-tx" is not supported in driver,
> > and in fact uses "mediatek,mt2701-mipi-tx" instead on MT7623, so changes
> > the compatible items to make dependence clear.
>
> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>

Sorry, please remove my reviewed-by tag. We should not define the
binding document according to the implementation of driver. We define
the binding document according to the hardware. So the description
should be like "mt7623-mipi-tx is compatible to mt2701-mipi-tx".

Regards,
Chun-Kuang.

>
> >
> > Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > v2: separate two patches suggested by CK
> > ---
> >  .../devicetree/bindings/phy/mediatek,dsi-phy.yaml   | 13 ++++++++-----
> >  1 file changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > index 71d4acea1f66..6e4d795f9b02 100644
> > --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > @@ -19,11 +19,14 @@ properties:
> >      pattern: "^dsi-phy@[0-9a-f]+$"
> >
> >    compatible:
> > -    enum:
> > -      - mediatek,mt2701-mipi-tx
> > -      - mediatek,mt7623-mipi-tx
> > -      - mediatek,mt8173-mipi-tx
> > -      - mediatek,mt8183-mipi-tx
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - mediatek,mt7623-mipi-tx
> > +          - const: mediatek,mt2701-mipi-tx
> > +      - const: mediatek,mt2701-mipi-tx
> > +      - const: mediatek,mt8173-mipi-tx
> > +      - const: mediatek,mt8183-mipi-tx
> >
> >    reg:
> >      maxItems: 1
> > --
> > 2.18.0
Chunfeng Yun Jan. 25, 2021, 6:21 a.m. UTC | #3
On Sun, 2021-01-24 at 12:56 +0800, Chun-Kuang Hu wrote:
> Hi, Chunfeng:
> 
> Chun-Kuang Hu <chunkuang.hu@kernel.org> 於 2021年1月24日 週日 下午12:47寫道:
> >
> > Hi, Chunfeng:
> >
> > Chunfeng Yun <chunfeng.yun@mediatek.com> 於 2021年1月22日 週五 下午8:04寫道:
> > >
> > > The compatilbe "mediatek,mt7623-mipi-tx" is not supported in driver,
> > > and in fact uses "mediatek,mt2701-mipi-tx" instead on MT7623, so changes
> > > the compatible items to make dependence clear.
> >
> > Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> 
> Sorry, please remove my reviewed-by tag. We should not define the
> binding document according to the implementation of driver. We define
> the binding document according to the hardware. So the description
> should be like "mt7623-mipi-tx is compatible to mt2701-mipi-tx".
Ok, will make the description clearer

> 
> Regards,
> Chun-Kuang.
> 
> >
> > >
> > > Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > ---
> > > v2: separate two patches suggested by CK
> > > ---
> > >  .../devicetree/bindings/phy/mediatek,dsi-phy.yaml   | 13 ++++++++-----
> > >  1 file changed, 8 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > > index 71d4acea1f66..6e4d795f9b02 100644
> > > --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > > +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > > @@ -19,11 +19,14 @@ properties:
> > >      pattern: "^dsi-phy@[0-9a-f]+$"
> > >
> > >    compatible:
> > > -    enum:
> > > -      - mediatek,mt2701-mipi-tx
> > > -      - mediatek,mt7623-mipi-tx
> > > -      - mediatek,mt8173-mipi-tx
> > > -      - mediatek,mt8183-mipi-tx
> > > +    oneOf:
> > > +      - items:
> > > +          - enum:
> > > +              - mediatek,mt7623-mipi-tx
> > > +          - const: mediatek,mt2701-mipi-tx
> > > +      - const: mediatek,mt2701-mipi-tx
> > > +      - const: mediatek,mt8173-mipi-tx
> > > +      - const: mediatek,mt8183-mipi-tx
> > >
> > >    reg:
> > >      maxItems: 1
> > > --
> > > 2.18.0
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
index 71d4acea1f66..6e4d795f9b02 100644
--- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
@@ -19,11 +19,14 @@  properties:
     pattern: "^dsi-phy@[0-9a-f]+$"
 
   compatible:
-    enum:
-      - mediatek,mt2701-mipi-tx
-      - mediatek,mt7623-mipi-tx
-      - mediatek,mt8173-mipi-tx
-      - mediatek,mt8183-mipi-tx
+    oneOf:
+      - items:
+          - enum:
+              - mediatek,mt7623-mipi-tx
+          - const: mediatek,mt2701-mipi-tx
+      - const: mediatek,mt2701-mipi-tx
+      - const: mediatek,mt8173-mipi-tx
+      - const: mediatek,mt8183-mipi-tx
 
   reg:
     maxItems: 1