diff mbox series

[next,v2,04/17] dt-bindings: phy: mediatek: dsi-phy: add optional clock-names

Message ID 20210122120323.4337-4-chunfeng.yun@mediatek.com (mailing list archive)
State New, archived
Headers show
Series [next,v2,01/17] dt-bindings: usb: fix yamllint check warning | expand

Commit Message

Chunfeng Yun Jan. 22, 2021, 12:03 p.m. UTC
Add an optional "clock-names" property, it's not used to get the clock,
but some DTS files (e.g. mt8183) provide it.

Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2: new patch separated from [3/15] suggested by CK
---
 Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Chun-Kuang Hu Jan. 23, 2021, 12:18 a.m. UTC | #1
Hi, Chunfeng:

Chunfeng Yun <chunfeng.yun@mediatek.com> 於 2021年1月22日 週五 下午8:04寫道:
>
> Add an optional "clock-names" property, it's not used to get the clock,
> but some DTS files (e.g. mt8183) provide it.

I think the logic is that we define property in binding document
first, and then write it in device tree. If a property does not exist
in binding document, we should not write it in device tree. So let's
drop this patch and remove clock-names in mt8183.dtsi.

Regards,
Chun-Kuang.

>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v2: new patch separated from [3/15] suggested by CK
> ---
>  Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> index 6e4d795f9b02..af6e554c5b69 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> @@ -35,6 +35,10 @@ properties:
>      items:
>        - description: PLL reference clock
>
> +  clock-names:
> +    items:
> +      - const: ref
> +
>    clock-output-names:
>      maxItems: 1
>
> --
> 2.18.0
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
Chunfeng Yun Jan. 25, 2021, 6:19 a.m. UTC | #2
On Sat, 2021-01-23 at 08:18 +0800, Chun-Kuang Hu wrote:
> Hi, Chunfeng:
> 
> Chunfeng Yun <chunfeng.yun@mediatek.com> 於 2021年1月22日 週五 下午8:04寫道:
> >
> > Add an optional "clock-names" property, it's not used to get the clock,
> > but some DTS files (e.g. mt8183) provide it.
> 
> I think the logic is that we define property in binding document
> first, and then write it in device tree. If a property does not exist
> in binding document, we should not write it in device tree. So let's
> drop this patch and remove clock-names in mt8183.dtsi.
Ok, It's better to remove unnecessary property.

> 
> Regards,
> Chun-Kuang.
> 
> >
> > Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > v2: new patch separated from [3/15] suggested by CK
> > ---
> >  Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > index 6e4d795f9b02..af6e554c5b69 100644
> > --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > @@ -35,6 +35,10 @@ properties:
> >      items:
> >        - description: PLL reference clock
> >
> > +  clock-names:
> > +    items:
> > +      - const: ref
> > +
> >    clock-output-names:
> >      maxItems: 1
> >
> > --
> > 2.18.0
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
index 6e4d795f9b02..af6e554c5b69 100644
--- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
@@ -35,6 +35,10 @@  properties:
     items:
       - description: PLL reference clock
 
+  clock-names:
+    items:
+      - const: ref
+
   clock-output-names:
     maxItems: 1