| Message ID | 20210201111310.3231469-4-nakamura.shun@jp.fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | perf vendor events: Support PMU events for A64FX | expand |
On 01/02/2021 11:13, Shunsuke Nakamura wrote: > Fix the lexical definition of event name so that the numbers are recognizable. > > A64FX defines an event name that starts with a number. > - 0inst_commit > - 1inst_commit > - 2inst_commit > - 3inst_commit > - 4inst_commit > > Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com> eh... I'm not sure if you will encounter other problems, so may be prudent to change the event name to not start with a number. Someone else may also advise on this. > --- > tools/perf/util/parse-events.l | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > index 9db5097..e6bbbd0 100644 > --- a/tools/perf/util/parse-events.l > +++ b/tools/perf/util/parse-events.l > @@ -205,7 +205,7 @@ bpf_source [^,{}]+\.c[a-zA-Z0-9._]* > num_dec [0-9]+ > num_hex 0x[a-fA-F0-9]+ > num_raw_hex [a-fA-F0-9]+ > -name [a-zA-Z_*?\[\]][a-zA-Z0-9_*?.\[\]]* > +name [a-zA-Z0-9_*?\[\]][a-zA-Z0-9_*?.\[\]]* > name_tag [\'][a-zA-Z_*?\[\]][a-zA-Z0-9_*?\-,\.\[\]:=]*[\'] > name_minus [a-zA-Z_*?][a-zA-Z0-9\-_*?.:]* > drv_cfg_term [a-zA-Z0-9_\.]+(=[a-zA-Z0-9_*?\.:]+)? >
Hi, John I have applied this patch and confirmed that the event can be specified correctly. Event names are defined in the A64FX specification. I want to deal with it at that time if there is a problem. So I would like to resend the v5 patch and wait for advice from others. Best Regards Shunsuke
(I missed to include the quotation in the text. Will resend. Sorry about that.) Hi, John > > Fix the lexical definition of event name so that the numbers are recognizable. > > > > A64FX defines an event name that starts with a number. > > - 0inst_commit > > - 1inst_commit > > - 2inst_commit > > - 3inst_commit > > - 4inst_commit > > > > Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com> > > eh... I'm not sure if you will encounter other problems, so may be prudent to > change the event name to not start with a number. Someone else may also advise > on this. I have applied this patch and confirmed that the event can be specified correctly. Event names are defined in the A64FX specification. I want to deal with it at that time if there is a problem. So I would like to resend the v5 patch and wait for advice from others. Best Regards Shunsuke
diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l index 9db5097..e6bbbd0 100644 --- a/tools/perf/util/parse-events.l +++ b/tools/perf/util/parse-events.l @@ -205,7 +205,7 @@ bpf_source [^,{}]+\.c[a-zA-Z0-9._]* num_dec [0-9]+ num_hex 0x[a-fA-F0-9]+ num_raw_hex [a-fA-F0-9]+ -name [a-zA-Z_*?\[\]][a-zA-Z0-9_*?.\[\]]* +name [a-zA-Z0-9_*?\[\]][a-zA-Z0-9_*?.\[\]]* name_tag [\'][a-zA-Z_*?\[\]][a-zA-Z0-9_*?\-,\.\[\]:=]*[\'] name_minus [a-zA-Z_*?][a-zA-Z0-9\-_*?.:]* drv_cfg_term [a-zA-Z0-9_\.]+(=[a-zA-Z0-9_*?\.:]+)?
Fix the lexical definition of event name so that the numbers are recognizable. A64FX defines an event name that starts with a number. - 0inst_commit - 1inst_commit - 2inst_commit - 3inst_commit - 4inst_commit Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com> --- tools/perf/util/parse-events.l | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)