diff mbox series

arm64/ptdump:display the Linear Mapping start marker

Message ID 20210202150749.10104-1-liuhailongg6@163.com (mailing list archive)
State New, archived
Headers show
Series arm64/ptdump:display the Linear Mapping start marker | expand

Commit Message

Hailong Liu Feb. 2, 2021, 3:07 p.m. UTC
From: Hailong Liu <liu.hailong6@zte.com.cn>

The current /sys/kernel/debug/kernel_page_tables does not display the
*Linear Mapping start* marker on arm64, which I think should be paired
with the *Linear Mapping start* marker.

Since *Linear Mapping start* is the first marker, use level=-1 to display it.

Signed-off-by: Hailong Liu <liu.hailong6@zte.com.cn>
---
 arch/arm64/mm/ptdump.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Randy Dunlap Feb. 2, 2021, 7:39 p.m. UTC | #1
On 2/2/21 7:07 AM, Hailong Liu wrote:
> From: Hailong Liu <liu.hailong6@zte.com.cn>
> 
> The current /sys/kernel/debug/kernel_page_tables does not display the
> *Linear Mapping start* marker on arm64, which I think should be paired
> with the *Linear Mapping start* marker.

paired with itself?  just asking...

> 
> Since *Linear Mapping start* is the first marker, use level=-1 to display it.
> 
> Signed-off-by: Hailong Liu <liu.hailong6@zte.com.cn>
> ---
>  arch/arm64/mm/ptdump.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/mm/ptdump.c b/arch/arm64/mm/ptdump.c
> index 04137a8f3d2d..0e050d76b83a 100644
> --- a/arch/arm64/mm/ptdump.c
> +++ b/arch/arm64/mm/ptdump.c
> @@ -324,6 +324,7 @@ void ptdump_walk(struct seq_file *s, struct ptdump_info *info)
>  	st = (struct pg_state){
>  		.seq = s,
>  		.marker = info->markers,
> +		.level = -1,
>  		.ptdump = {
>  			.note_page = note_page,
>  			.range = (struct ptdump_range[]){
>
Will Deacon Feb. 2, 2021, 9:25 p.m. UTC | #2
On Tue, 2 Feb 2021 23:07:49 +0800, Hailong Liu wrote:
> The current /sys/kernel/debug/kernel_page_tables does not display the
> *Linear Mapping start* marker on arm64, which I think should be paired
> with the *Linear Mapping start* marker.
> 
> Since *Linear Mapping start* is the first marker, use level=-1 to display it.

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64/ptdump:display the Linear Mapping start marker
      https://git.kernel.org/arm64/c/b9ba680969d1

Cheers,
Hailong Liu Feb. 3, 2021, 2:13 p.m. UTC | #3
On 2/3/21 3:39 AM, Randy Dunlap wrote:
> On 2/2/21 7:07 AM, Hailong Liu wrote:
>> From: Hailong Liu <liu.hailong6@zte.com.cn>
>>
>> The current /sys/kernel/debug/kernel_page_tables does not display the
>> *Linear Mapping start* marker on arm64, which I think should be paired
>> with the *Linear Mapping start* marker.
> 
> paired with itself?  just asking.
Oh,sorry, it's a mistake. My original intention is to express that "start"
paired with "end".

Thanks for pointing out my mistake, and thank Will for fixing this.
diff mbox series

Patch

diff --git a/arch/arm64/mm/ptdump.c b/arch/arm64/mm/ptdump.c
index 04137a8f3d2d..0e050d76b83a 100644
--- a/arch/arm64/mm/ptdump.c
+++ b/arch/arm64/mm/ptdump.c
@@ -324,6 +324,7 @@  void ptdump_walk(struct seq_file *s, struct ptdump_info *info)
 	st = (struct pg_state){
 		.seq = s,
 		.marker = info->markers,
+		.level = -1,
 		.ptdump = {
 			.note_page = note_page,
 			.range = (struct ptdump_range[]){