| Message ID | 20210215231943.36910-2-adrien.grassein@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add peripheral support for imx8mm-nitrogen-r2 board | expand |
On Tue, Feb 16, 2021 at 12:19:36AM +0100, Adrien Grassein wrote: > Add usdhc3 description which corresponds to the wifi/bt chip > > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> > --- > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 31 +++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > index c0c384d76147..bf20a40bcda0 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > @@ -9,6 +9,18 @@ > / { > model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; > compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; > + > + reg_wlan_vmmc: regulator-wlan-vmmc { > + compatible = "regulator-fixed"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_reg_wlan_vmmc>; > + regulator-name = "reg_wlan_vmmc"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + startup-delay-us = <70000>; That's quite a startup time... and it happens is the same as in bindings example. Do you really need it or it was just copied? I actually don't mind it, just poking at various things. :) > + }; > }; > > &A53_0 { > @@ -206,6 +218,19 @@ &usdhc2 { > status = "okay"; > }; > > +/* wlan */ > +&usdhc3 { > + bus-width = <4>; > + sdhci-caps-mask = <0x2 0x0>; > + non-removable; > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > + pinctrl-0 = <&pinctrl_usdhc3>; > + pinctrl-1 = <&pinctrl_usdhc3_100mhz>; > + pinctrl-2 = <&pinctrl_usdhc3_200mhz>; > + vmmc-supply = <®_wlan_vmmc>; What about vqmmc? Best regards, Krzysztof
Hello, Thanks for your review and your time. Le mer. 17 févr. 2021 à 12:58, Krzysztof Kozlowski <krzk@kernel.org> a écrit : > > On Tue, Feb 16, 2021 at 12:19:36AM +0100, Adrien Grassein wrote: > > Add usdhc3 description which corresponds to the wifi/bt chip > > > > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> > > --- > > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 31 +++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > > index c0c384d76147..bf20a40bcda0 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > > @@ -9,6 +9,18 @@ > > / { > > model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; > > compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; > > + > > + reg_wlan_vmmc: regulator-wlan-vmmc { > > + compatible = "regulator-fixed"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_reg_wlan_vmmc>; > > + regulator-name = "reg_wlan_vmmc"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + startup-delay-us = <70000>; > > That's quite a startup time... and it happens is the same as in bindings > example. Do you really need it or it was just copied? > > I actually don't mind it, just poking at various things. :) > It was a copy/paste. I've just retested without this, it works. > > + }; > > }; > > > > &A53_0 { > > @@ -206,6 +218,19 @@ &usdhc2 { > > status = "okay"; > > }; > > > > +/* wlan */ > > +&usdhc3 { > > + bus-width = <4>; > > + sdhci-caps-mask = <0x2 0x0>; > > + non-removable; > > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > > + pinctrl-0 = <&pinctrl_usdhc3>; > > + pinctrl-1 = <&pinctrl_usdhc3_100mhz>; > > + pinctrl-2 = <&pinctrl_usdhc3_200mhz>; > > + vmmc-supply = <®_wlan_vmmc>; > > What about vqmmc? > It was missing, thanks, > Best regards, > Krzysztof Best regards, Adrien
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts index c0c384d76147..bf20a40bcda0 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts @@ -9,6 +9,18 @@ / { model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; + + reg_wlan_vmmc: regulator-wlan-vmmc { + compatible = "regulator-fixed"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_reg_wlan_vmmc>; + regulator-name = "reg_wlan_vmmc"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>; + enable-active-high; + startup-delay-us = <70000>; + }; }; &A53_0 { @@ -206,6 +218,19 @@ &usdhc2 { status = "okay"; }; +/* wlan */ +&usdhc3 { + bus-width = <4>; + sdhci-caps-mask = <0x2 0x0>; + non-removable; + pinctrl-names = "default", "state_100mhz", "state_200mhz"; + pinctrl-0 = <&pinctrl_usdhc3>; + pinctrl-1 = <&pinctrl_usdhc3_100mhz>; + pinctrl-2 = <&pinctrl_usdhc3_200mhz>; + vmmc-supply = <®_wlan_vmmc>; + status = "okay"; +}; + &wdog1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_wdog>; @@ -264,6 +289,12 @@ MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 0x1c0 >; }; + pinctrl_reg_wlan_vmmc: reg-wlan-vmmcgrp { + fsl,pins = < + MX8MM_IOMUXC_SAI5_RXC_GPIO3_IO20 0x16 + >; + }; + pinctrl_uart2: uart2grp { fsl,pins = < MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140
Add usdhc3 description which corresponds to the wifi/bt chip Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> --- .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 31 +++++++++++++++++++ 1 file changed, 31 insertions(+)