diff mbox series

[09/13] serial: stm32: call stm32_transmit_chars locked

Message ID 20210219174736.1022-10-erwan.leray@foss.st.com (mailing list archive)
State New, archived
Headers show
Series stm32 usart various fixes | expand

Commit Message

Erwan Le Ray Feb. 19, 2021, 5:47 p.m. UTC
stm32_transmit_chars should be called under lock also in tx DMA callback.

Fixes: 3489187204eb ("serial: stm32: adding dma support")
Signed-off-by: Erwan Le Ray <erwan.leray@foss.st.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
diff mbox series


diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
index 7da16d468b84..bdd7ca490021 100644
--- a/drivers/tty/serial/stm32-usart.c
+++ b/drivers/tty/serial/stm32-usart.c
@@ -291,13 +291,16 @@  static void stm32_usart_tx_dma_complete(void *arg)
 	struct uart_port *port = arg;
 	struct stm32_port *stm32port = to_stm32_port(port);
 	struct stm32_usart_offsets *ofs = &stm32port->info->ofs;
+	unsigned long flags;
 	stm32_usart_clr_bits(port, ofs->cr3, USART_CR3_DMAT);
 	stm32port->tx_dma_busy = false;
 	/* Let's see if we have pending data to send */
+	spin_lock_irqsave(&port->lock, flags);
+	spin_unlock_irqrestore(&port->lock, flags);
 static void stm32_usart_tx_interrupt_enable(struct uart_port *port)