From patchwork Sat Feb 20 23:11:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marek_Beh=C3=BAn?= X-Patchwork-Id: 12097103 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED5EC433DB for ; Sat, 20 Feb 2021 23:14:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E47CF64DED for ; Sat, 20 Feb 2021 23:14:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E47CF64DED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=a7Ag7mD1UB04G2JZWaVIEvZtaJXefVnCCbxA6J/OIVw=; b=Fb9ikhNJGZe8p6hF81iGNG0beI Ylyl80jUXz+HfOYTOZn0646toe5ADVACj0EI5QhyXVDncOxQ7f99u9UP0Ma26AiJmrLsZT3WL6pDD isakViEwSk54xxSRchqQRnx9++f5TDj8on1Mf/j+j4eH7RQ4nBJD+P01eEv31i8MYAo8JWJwl1kHB RInsmXlH6E41BxpBtEQc5i5HHs1JutujxE0HP1ce9FD5l5XH18H/24saq/6cdYJtV1j099Sc/6Pm2 C4OethCGSsmpbvos8fkOmdwUZNCkl3B9451DlsLYFtNuSty6CPyVQnfuMH9eE1mSr9WuDmvKinKk8 p++2aOKg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDbQ3-0003rw-92; Sat, 20 Feb 2021 23:12:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDbQ0-0003rO-CF for linux-arm-kernel@lists.infradead.org; Sat, 20 Feb 2021 23:12:09 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 51D9664EB8; Sat, 20 Feb 2021 23:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613862726; bh=u7qHB3S8G0lDGgctj7hnk3Ftm2wmMqZUJjxJBtDhpoc=; h=From:To:Cc:Subject:Date:From; b=UodP6zDtTn2rRt4+ehbVCIW17ZhEeFqUvsdVPd3AtqHA/4qMCvYrcMUfBAyvkIxxE iolOJx4zAZ4rGDwpe/J1/qcEYjThxGJEEGVG0GEsEagBhf/rqGS9svyIwwikGShnNp oQDyWWm8GLipj7RmEQqFLhp+q9dHupSLChJY1X5Zxo1if/4UB0tqjTzH9Q33YiYK6z Pg4gPROOMnnfHDZhK7w7sh56FVWJgGSSX4ZHOuQFsKQeqW17tsnG2LT56tA9WhjzcL qwLadqhl1tLgfOO4enBPGnwMxa7L8mWBhWo0nEO3aSMCEXbLPqk+ZHzRpf36rRxKhd pFYAYcAcfN7SQ== From: =?utf-8?q?Marek_Beh=C3=BAn?= To: Gregory CLEMENT Subject: [PATCH mvebu-dt] ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin Date: Sun, 21 Feb 2021 00:11:44 +0100 Message-Id: <20210220231144.32325-1-kabel@kernel.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210220_181208_605297_E8F22220 X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Marek_Beh=C3=BAn?= , Andrew Lunn , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , stable@vger.kernel.org, Rui Salvaterra , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use the `marvell,reg-init` DT property to configure the LED[2]/INTn pin of the Marvell 88E1514 ethernet PHY on Turris Omnia into interrupt mode. Without this the pin is by default in LED[2] mode, and the Marvell PHY driver configures LED[2] into "On - Link, Blink - Activity" mode. This fixes the issue where the pca9538 GPIO/interrupt controller (which can't mask interrupts in HW) received too many interrupts and after a time started ignoring the interrupt with error message: IRQ 71: nobody cared There is a work in progress to have the Marvell PHY driver support parsing PHY LED nodes from OF and registering the LEDs as Linux LED class devices. Once this is done the PHY driver can also automatically set the pin into INTn mode if it does not find LED[2] in OF. Until then, though, we fix this via `marvell,reg-init` DT property. Signed-off-by: Marek Behún Reported-by: Rui Salvaterra Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia") Cc: Uwe Kleine-König Cc: linux-arm-kernel@lists.infradead.org Cc: Andrew Lunn Cc: Gregory CLEMENT Cc: Tested-by: Rui Salvaterra Reviewed-by: Andrew Lunn --- This patch fixes bug introduced with the commit that added Turris Omnia's DTS (26ca8b52d6e1), but will not apply cleanly because there is commit 8ee4a5f4f40d which changed node name and node compatible property and this commit did not go into stable. So either commit 8ee4a5f4f40d has also to go into stable before this, or this patch has to be fixed a little in order to apply to 4.14+. Please let me know how should I handle this. --- arch/arm/boot/dts/armada-385-turris-omnia.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts index 646a06420c77..b0f3fd8e1429 100644 --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts @@ -389,6 +389,7 @@ &mdio { phy1: ethernet-phy@1 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <1>; + marvell,reg-init = <3 18 0 0x4985>; /* irq is connected to &pcawan pin 7 */ };