From patchwork Wed Mar 3 13:29:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 12113761 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24147C433E6 for ; Wed, 3 Mar 2021 16:11:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9972B64EE4 for ; Wed, 3 Mar 2021 16:11:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9972B64EE4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=glider.be Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=XuqsNksX/gV8RtHuCy9F/kbNOanbmVkCtB03i+AFod8=; b=lF3r7qNuaJeZqyfHt5gk77sePK 2+KWmdYu2RDWe0EMaNaqKkbbgNA5Ye3HE0u9OCQyOEH/4eu2MqXUXYHnDafF2EeihkRGzs26aTpya KDUuQpmslrhnx/gSHeRWi39d1CmKlzNL9SkgZJLWtA0volt5Toir99I5WIkQSv3os80AGCfUG0MYf dp+VUU5LOIOwIzRYLkHDv9fMtqWwNWa5YpYM+ud+/fn8So/f0mKk40oXpjUPkxJFCMKy+cXAPhy2D UMU75iBEiZQpYhlBYvFHW8IfRDzKwG/+TxlldNMIer1Cg/da+IED6VOzwda1UeOKk8hC6PdGFRgbi d7CkHQfA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHU3W-005XT6-1H; Wed, 03 Mar 2021 16:08:58 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHSon-005DiD-5s for linux-arm-kernel@desiato.infradead.org; Wed, 03 Mar 2021 14:49:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=iHmpC4c/vC0WWRThUE6Ba3SPGacRcP3X8TMpcs/yFvU=; b=FpU8nxTx5OyGGMWxxqA5y6LRcx 4ew/NyY9rISJkry+FZb150FFia+mJIlQbVhiWXFps+/GwXn2gmNQT2Q5AMwcUnsKgiVjtIxf1uvYL rnbVsr3dJLVG1q0VK2O1hAaf+k24Qf8+/ukhJL1DocEqjRJrkryszFBLTIxv/iEIGNTix8hqkFKx7 ba7A6GWGDUyHHxvKyk429R7noLpXDr7+YUXearDgqzGHrwhSDBOaZzB+T+tajtB0zONZyxMW/ti4m yMg24YkkbnqHzUNwXyIz7E3It0B3TytO/hYcv/7ztWIt/uKp2khqqWRKJuEZCGG4hImMZUnRJb5pf eoP5bo3Q==; Received: from newton.telenet-ops.be ([2a02:1800:120:4::f00:d]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHRZX-002lZZ-J8 for linux-arm-kernel@lists.infradead.org; Wed, 03 Mar 2021 13:29:53 +0000 Received: from laurent.telenet-ops.be (laurent.telenet-ops.be [IPv6:2a02:1800:110:4::f00:19]) by newton.telenet-ops.be (Postfix) with ESMTPS id 4DrFGg5L4SzMqgdB for ; Wed, 3 Mar 2021 14:29:47 +0100 (CET) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed20:cd47:42a6:c822:e50b]) by laurent.telenet-ops.be with bizsmtp id bpVj2400d4huzR801pVjVg; Wed, 03 Mar 2021 14:29:44 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lHRZP-004Pt3-Az; Wed, 03 Mar 2021 14:29:43 +0100 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from ) id 1lHRZO-00GWbD-So; Wed, 03 Mar 2021 14:29:42 +0100 From: Geert Uytterhoeven To: Magnus Damm Cc: Ulrich Hecht , Linus Walleij , linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven Subject: [PATCH] ARM: dts: koelsch: Configure pull-up for SOFT_SW GPIO keys Date: Wed, 3 Mar 2021 14:29:41 +0100 Message-Id: <20210303132941.3938516-1-geert+renesas@glider.be> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_132953_271204_6B55C1A5 X-CRM114-Status: GOOD ( 10.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The GPIO pins connected to the 4 Software Switches ("SOFT_SW", SW2) do not have external pull-up resistors, but rely on internal pull-ups being enabled. Fortunately this is satisfied by the initial state of these pins. Make this explicit by enabling bias-pull-up, to remove the dependency on initial state and/or boot loader configuration. Signed-off-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund --- To be queued in renesas-devel for v5.13. It is safe to apply this before R-Car M2-W bias support[1] has landed, as pinctrl_bind_pins() does not consider -ENOTSUPP a fatal error. [1] https://lore.kernel.org/r/20210303132619.3938128-1-geert+renesas@glider.be --- arch/arm/boot/dts/r8a7791-koelsch.dts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts index 751e07fb102cf454..c6c93c4452ee1e88 100644 --- a/arch/arm/boot/dts/r8a7791-koelsch.dts +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts @@ -81,6 +81,9 @@ lbsc { keyboard { compatible = "gpio-keys"; + pinctrl-0 = <&sw2_pins>; + pinctrl-names = "default"; + key-1 { gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; linux,code = ; @@ -615,6 +618,11 @@ sound_clk_pins: sound_clk { groups = "audio_clk_a"; function = "audio_clk"; }; + + sw2_pins: sw2 { + pins = "GP_5_0", "GP_5_1", "GP_5_2", "GP_5_3"; + bias-pull-up; + }; }; ðer {