| Message ID | 20210305101841.3133721-4-nakamura.shun@fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | perf vendor events: Support PMU events for A64FX | expand |
On 05/03/2021 10:18, Shunsuke Nakamura wrote: > The perf parser does not support event names that start with a number. > This patch adds "_" to the event name, which starts with a number. > > Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com> I think that this can be folded into patch 2/3, and my reveiwed-by tag still stands for patch 2/3. Thanks > --- > .../pmu-events/arch/arm64/fujitsu/a64fx/other.json | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json b/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json > index 68b8e46d6140..10c823ac26cc 100644 > --- a/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json > +++ b/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json > @@ -98,31 +98,31 @@ > { > "PublicDescription": "This event counts every cycle that no instruction was committed, but counts at the time when commits MOVPRFX only.", > "EventCode": "0x190", > - "EventName": "0INST_COMMIT", > + "EventName": "_0INST_COMMIT", > "BriefDescription": "This event counts every cycle that no instruction was committed, but counts at the time when commits MOVPRFX only." > }, > { > "PublicDescription": "This event counts every cycle that one instruction is committed.", > "EventCode": "0x191", > - "EventName": "1INST_COMMIT", > + "EventName": "_1INST_COMMIT", > "BriefDescription": "This event counts every cycle that one instruction is committed." > }, > { > "PublicDescription": "This event counts every cycle that two instructions are committed.", > "EventCode": "0x192", > - "EventName": "2INST_COMMIT", > + "EventName": "_2INST_COMMIT", > "BriefDescription": "This event counts every cycle that two instructions are committed." > }, > { > "PublicDescription": "This event counts every cycle that three instructions are committed.", > "EventCode": "0x193", > - "EventName": "3INST_COMMIT", > + "EventName": "_3INST_COMMIT", > "BriefDescription": "This event counts every cycle that three instructions are committed." > }, > { > "PublicDescription": "This event counts every cycle that four instructions are committed.", > "EventCode": "0x194", > - "EventName": "4INST_COMMIT", > + "EventName": "_4INST_COMMIT", > "BriefDescription": "This event counts every cycle that four instructions are committed." > }, > { >
Hi, John > On 05/03/2021 10:18, Shunsuke Nakamura wrote: > > The perf parser does not support event names that start with a number. > > This patch adds "_" to the event name, which starts with a number. > > > > Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com> > > I think that this can be folded into patch 2/3, and my reveiwed-by tag > still stands for patch 2/3. I will fix it. Best Regards Shunsuke
diff --git a/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json b/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json index 68b8e46d6140..10c823ac26cc 100644 --- a/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json +++ b/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json @@ -98,31 +98,31 @@ { "PublicDescription": "This event counts every cycle that no instruction was committed, but counts at the time when commits MOVPRFX only.", "EventCode": "0x190", - "EventName": "0INST_COMMIT", + "EventName": "_0INST_COMMIT", "BriefDescription": "This event counts every cycle that no instruction was committed, but counts at the time when commits MOVPRFX only." }, { "PublicDescription": "This event counts every cycle that one instruction is committed.", "EventCode": "0x191", - "EventName": "1INST_COMMIT", + "EventName": "_1INST_COMMIT", "BriefDescription": "This event counts every cycle that one instruction is committed." }, { "PublicDescription": "This event counts every cycle that two instructions are committed.", "EventCode": "0x192", - "EventName": "2INST_COMMIT", + "EventName": "_2INST_COMMIT", "BriefDescription": "This event counts every cycle that two instructions are committed." }, { "PublicDescription": "This event counts every cycle that three instructions are committed.", "EventCode": "0x193", - "EventName": "3INST_COMMIT", + "EventName": "_3INST_COMMIT", "BriefDescription": "This event counts every cycle that three instructions are committed." }, { "PublicDescription": "This event counts every cycle that four instructions are committed.", "EventCode": "0x194", - "EventName": "4INST_COMMIT", + "EventName": "_4INST_COMMIT", "BriefDescription": "This event counts every cycle that four instructions are committed." }, {
The perf parser does not support event names that start with a number. This patch adds "_" to the event name, which starts with a number. Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com> --- .../pmu-events/arch/arm64/fujitsu/a64fx/other.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)