diff mbox series

[1/2] arm64: dts: imx8mp: add flexspi node

Message ID 20210308064046.1576267-2-hs@denx.de (mailing list archive)
State New, archived
Headers show
Series enable flexspi support on imx8mp | expand

Commit Message

Heiko Schocher March 8, 2021, 6:40 a.m. UTC
add node for the flexspi modul on imx8mp.

Signed-off-by: Heiko Schocher <hs@denx.de>

---

 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Marco Felsch March 8, 2021, 8:33 a.m. UTC | #1
Hi Heiko,

On 21-03-08 07:40, Heiko Schocher wrote:
> add node for the flexspi modul on imx8mp.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> 
> ---
> 
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index c7523fd4eae9b..086cfbbef43d7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -36,6 +36,7 @@ aliases {
>  		serial1 = &uart2;
>  		serial2 = &uart3;
>  		serial3 = &uart4;
> +		spi0 = &flexspi;
>  	};
>  
>  	cpus {
> @@ -744,6 +745,21 @@ usdhc3: mmc@30b60000 {
>  				status = "disabled";
>  			};
>  
> +			flexspi: spi@30bb0000 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;

This properties can moved to end just in front of the status property
which should be the last one.

> +				compatible = "nxp,imx8mm-fspi";

Please add a own compatible "nxp,imx8mp-fspi" to the driver which should
be the first patch in your series.

Also the compatible is always the first property.

Regards,
  Marco

> +				reg = <0x30bb0000 0x10000>, <0x8000000 0x10000000>;
> +				reg-names = "fspi_base", "fspi_mmap";
> +				interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clk IMX8MP_CLK_QSPI_ROOT>,
> +					 <&clk IMX8MP_CLK_QSPI_ROOT>;
> +				clock-names = "fspi", "fspi_en";
> +				assigned-clock-rates = <80000000>;
> +				assigned-clocks = <&clk IMX8MP_CLK_QSPI>;
> +				status = "disabled";
> +			};
> +
>  			sdma1: dma-controller@30bd0000 {
>  				compatible = "fsl,imx8mp-sdma", "fsl,imx8mq-sdma";
>  				reg = <0x30bd0000 0x10000>;
> -- 
> 2.29.2
> 
> 
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index c7523fd4eae9b..086cfbbef43d7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -36,6 +36,7 @@  aliases {
 		serial1 = &uart2;
 		serial2 = &uart3;
 		serial3 = &uart4;
+		spi0 = &flexspi;
 	};
 
 	cpus {
@@ -744,6 +745,21 @@  usdhc3: mmc@30b60000 {
 				status = "disabled";
 			};
 
+			flexspi: spi@30bb0000 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				compatible = "nxp,imx8mm-fspi";
+				reg = <0x30bb0000 0x10000>, <0x8000000 0x10000000>;
+				reg-names = "fspi_base", "fspi_mmap";
+				interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clk IMX8MP_CLK_QSPI_ROOT>,
+					 <&clk IMX8MP_CLK_QSPI_ROOT>;
+				clock-names = "fspi", "fspi_en";
+				assigned-clock-rates = <80000000>;
+				assigned-clocks = <&clk IMX8MP_CLK_QSPI>;
+				status = "disabled";
+			};
+
 			sdma1: dma-controller@30bd0000 {
 				compatible = "fsl,imx8mp-sdma", "fsl,imx8mq-sdma";
 				reg = <0x30bd0000 0x10000>;